Click here to Skip to main content
15,919,178 members

Welcome to the Lounge

   

For discussing anything related to a software developer's life but is not for programming questions. Got a programming question?

The Lounge is rated Safe For Work. If you're about to post something inappropriate for a shared office environment, then don't post it. No ads, no abuse, and no programming questions. Trolling, (political, climate, religious or whatever) will result in your account being removed.

 
GeneralRe: Code Review - thoughts Pin
Marc Clifton31-Jan-15 2:43
mvaMarc Clifton31-Jan-15 2:43 
GeneralRe: Code Review - thoughts Pin
jschell3-Feb-15 10:51
jschell3-Feb-15 10:51 
AnswerRe: Code Review - thoughts Pin
Munchies_Matt29-Jan-15 5:18
Munchies_Matt29-Jan-15 5:18 
GeneralRe: Code Review - thoughts Pin
Marc Clifton29-Jan-15 5:55
mvaMarc Clifton29-Jan-15 5:55 
AnswerRe: Code Review - thoughts Pin
Jörgen Andersson29-Jan-15 7:00
professionalJörgen Andersson29-Jan-15 7:00 
AnswerRe: Code Review - thoughts Pin
Sander Rossel29-Jan-15 7:57
professionalSander Rossel29-Jan-15 7:57 
GeneralRe: Code Review - thoughts Pin
Slacker00729-Jan-15 8:02
professionalSlacker00729-Jan-15 8:02 
GeneralRe: Code Review - thoughts Pin
Sander Rossel29-Jan-15 8:14
professionalSander Rossel29-Jan-15 8:14 
Maybe I should rephrase that:
I think code reviews would be great if they were done by someone who is at my level or above rather than by someone who thinks he's better or who is assumed to be better than me (or whoever wrote the code).
And that happened a few times in my case. The reviewer, technical director even, who came questioning me for using interfaces and asking why I created an interface AND a base class and then wanted some sources stating that you should use both... D'Oh! | :doh:
And how are you going to measure who is better anyway? Years of experience? Job title? Both are pretty weak as the person I just talked about had eight years more experience and was technical director while I had one year experience and was a junior Smile | :)
My blog[^]
C#
public class SanderRossel : Lazy<Person>
{
   public void DoWork()
   {
      throw new NotSupportedException();
   }
}

GeneralRe: Code Review - thoughts Pin
Slacker00729-Jan-15 8:24
professionalSlacker00729-Jan-15 8:24 
GeneralRe: Code Review - thoughts Pin
Sander Rossel29-Jan-15 8:52
professionalSander Rossel29-Jan-15 8:52 
GeneralRe: Code Review - thoughts Pin
jschell30-Jan-15 11:01
jschell30-Jan-15 11:01 
AnswerRe: Code Review - thoughts Pin
Super Lloyd29-Jan-15 13:16
Super Lloyd29-Jan-15 13:16 
AnswerRe: Code Review - thoughts Pin
Simon Lee Shugar29-Jan-15 22:32
Simon Lee Shugar29-Jan-15 22:32 
GeneralRe: Code Review - thoughts Pin
Slacker00730-Jan-15 5:12
professionalSlacker00730-Jan-15 5:12 
AnswerRe: Code Review - thoughts Pin
coding4ever30-Jan-15 2:31
professionalcoding4ever30-Jan-15 2:31 
AnswerRe: Code Review - thoughts Pin
tom144330-Jan-15 3:03
tom144330-Jan-15 3:03 
GeneralRe: Code Review - thoughts Pin
Slacker00730-Jan-15 5:07
professionalSlacker00730-Jan-15 5:07 
AnswerRe: Code Review - thoughts Pin
agolddog30-Jan-15 3:50
agolddog30-Jan-15 3:50 
GeneralRe: Code Review - thoughts Pin
Slacker00730-Jan-15 5:05
professionalSlacker00730-Jan-15 5:05 
AnswerRe: Code Review - thoughts Pin
Kirk 1038982130-Jan-15 4:31
Kirk 1038982130-Jan-15 4:31 
AnswerRe: Code Review - thoughts Pin
PIEBALDconsult30-Jan-15 4:40
mvePIEBALDconsult30-Jan-15 4:40 
AnswerRe: Code Review - thoughts Pin
Clint Helton30-Jan-15 5:25
Clint Helton30-Jan-15 5:25 
AnswerRe: Code Review - thoughts Pin
patbob30-Jan-15 5:47
patbob30-Jan-15 5:47 
GeneralRe: Code Review - thoughts Pin
Slacker00730-Jan-15 6:35
professionalSlacker00730-Jan-15 6:35 
GeneralHow cool is that? Pin
Kenneth Haugland29-Jan-15 4:38
mvaKenneth Haugland29-Jan-15 4:38 

General General    News News    Suggestion Suggestion    Question Question    Bug Bug    Answer Answer    Joke Joke    Praise Praise    Rant Rant    Admin Admin   

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.