Click here to Skip to main content
15,919,178 members

Welcome to the Lounge

   

For discussing anything related to a software developer's life but is not for programming questions. Got a programming question?

The Lounge is rated Safe For Work. If you're about to post something inappropriate for a shared office environment, then don't post it. No ads, no abuse, and no programming questions. Trolling, (political, climate, religious or whatever) will result in your account being removed.

 
AnswerRe: Code Review - thoughts Pin
Munchies_Matt29-Jan-15 5:18
Munchies_Matt29-Jan-15 5:18 
GeneralRe: Code Review - thoughts Pin
Marc Clifton29-Jan-15 5:55
mvaMarc Clifton29-Jan-15 5:55 
AnswerRe: Code Review - thoughts Pin
Jörgen Andersson29-Jan-15 7:00
professionalJörgen Andersson29-Jan-15 7:00 
AnswerRe: Code Review - thoughts Pin
Sander Rossel29-Jan-15 7:57
professionalSander Rossel29-Jan-15 7:57 
GeneralRe: Code Review - thoughts Pin
Slacker00729-Jan-15 8:02
professionalSlacker00729-Jan-15 8:02 
GeneralRe: Code Review - thoughts Pin
Sander Rossel29-Jan-15 8:14
professionalSander Rossel29-Jan-15 8:14 
GeneralRe: Code Review - thoughts Pin
Slacker00729-Jan-15 8:24
professionalSlacker00729-Jan-15 8:24 
GeneralRe: Code Review - thoughts Pin
Sander Rossel29-Jan-15 8:52
professionalSander Rossel29-Jan-15 8:52 
If my boss didn't agree with me using good programming practices, such as relying on abstractions, then that's not a company/team I want to work for (unless, of course, there's a very good reason not to do it). The problem in my above example wasn't that I used an interface, but that I used an interface and implemented it in a base class that could be inherited. The interface was there for people who did not need the base class or who had already inherited from other classes. This was actually a little tool that would be used by different programmers and in different solutions, so you need to be SOLID (another set of principles I had to defend) and make use of design patterns (I still hear the guy screaming "IN MY EIGHT YEARS OF EXPERIENCE I'VE NEVER HEARD OF DESIGN PATTERNS BEFORE! SHOW ME THAT MICROSOFT USES THEM AND I'LL RECONSIDER YOUR CODE!"). The next day he came to apologize and he had looked up some design patterns that Microsoft uses in .NET. In the end I got his job (sort of) and he and I weren't put on the same team anymore (he was still my boss, co-owner of the company).
I actually owe the guy quite a bit since he taught me programming (the first few months). I made up by writing pretty awesome software (that was something we all agreed on) that the company has successfully used for years.
In hindsight I could've dealt with him a bit different (I called his code a card house), but I was young and arrogant (and I still am a bit) and let's just say he and I didn't go well together.
We thanked each other last month when I left the company (on good terms) to learn at another company. I guess all's well that ends well Smile | :)

Slacker007 wrote:
Good luck to you and your career. Thumbs Up | :thumbsup:
Thanks, it's going pretty swell actually! Thumbs Up | :thumbsup:
You too, of course. Have fun with the code reviews Smile | :)
My blog[^]
C#
public class SanderRossel : Lazy<Person>
{
   public void DoWork()
   {
      throw new NotSupportedException();
   }
}

GeneralRe: Code Review - thoughts Pin
jschell30-Jan-15 11:01
jschell30-Jan-15 11:01 
AnswerRe: Code Review - thoughts Pin
Super Lloyd29-Jan-15 13:16
Super Lloyd29-Jan-15 13:16 
AnswerRe: Code Review - thoughts Pin
Simon Lee Shugar29-Jan-15 22:32
Simon Lee Shugar29-Jan-15 22:32 
GeneralRe: Code Review - thoughts Pin
Slacker00730-Jan-15 5:12
professionalSlacker00730-Jan-15 5:12 
AnswerRe: Code Review - thoughts Pin
coding4ever30-Jan-15 2:31
professionalcoding4ever30-Jan-15 2:31 
AnswerRe: Code Review - thoughts Pin
tom144330-Jan-15 3:03
tom144330-Jan-15 3:03 
GeneralRe: Code Review - thoughts Pin
Slacker00730-Jan-15 5:07
professionalSlacker00730-Jan-15 5:07 
AnswerRe: Code Review - thoughts Pin
agolddog30-Jan-15 3:50
agolddog30-Jan-15 3:50 
GeneralRe: Code Review - thoughts Pin
Slacker00730-Jan-15 5:05
professionalSlacker00730-Jan-15 5:05 
AnswerRe: Code Review - thoughts Pin
Kirk 1038982130-Jan-15 4:31
Kirk 1038982130-Jan-15 4:31 
AnswerRe: Code Review - thoughts Pin
PIEBALDconsult30-Jan-15 4:40
mvePIEBALDconsult30-Jan-15 4:40 
AnswerRe: Code Review - thoughts Pin
Clint Helton30-Jan-15 5:25
Clint Helton30-Jan-15 5:25 
AnswerRe: Code Review - thoughts Pin
patbob30-Jan-15 5:47
patbob30-Jan-15 5:47 
GeneralRe: Code Review - thoughts Pin
Slacker00730-Jan-15 6:35
professionalSlacker00730-Jan-15 6:35 
GeneralHow cool is that? Pin
Kenneth Haugland29-Jan-15 4:38
mvaKenneth Haugland29-Jan-15 4:38 
GeneralRe: How cool is that? Pin
Maximilien29-Jan-15 4:47
Maximilien29-Jan-15 4:47 
GeneralRe: How cool is that? Pin
Kenneth Haugland29-Jan-15 4:52
mvaKenneth Haugland29-Jan-15 4:52 

General General    News News    Suggestion Suggestion    Question Question    Bug Bug    Answer Answer    Joke Joke    Praise Praise    Rant Rant    Admin Admin   

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.