How to get all values in a single row

Question

0.00/5 (No votes)

See more:

SQL-Server-2005

Hi,
In my below sp after executing it..as EXEC sp_SplitVal

SQL

ALTER PROC sp_SplitVal
AS
DECLARE @Test VARCHAR(1000), @RecSet VARCHAR(500)
DECLARE @StartingPos INT,@RecPos INT
DECLARE @temptable TABLE(COMPLEXIONID INT)
SET @StartingPos= 1
SET @TEST='1,3,4,'
--SET @Test =(select cmp.complexion1 from customerexpectation cmp where cmp.customerid='4fe6559c-bc93-4d9c-bcb2-013fede7d969')
WHILE 
    @StartingPos<=LEN(@Test)
BEGIN
    SELECT @RecPos = CHARINDEX(',',@Test,@StartingPos)
    SET @RecSet=SUBSTRING(@Test,@StartingPos,@RecPos-@StartingPos)
    PRINT @RecSet
    BEGIN
        INSERT INTO @temptable VALUES(@RecSet)
        SELECT * FROM @temptable
        SELECT @StartingPos=@RecPos+1
    END
END

i am getting the results in a loop for three times..as

XML

COMPLEXIONID
     1
COMPLEXIONID
     1
     3
COMPLEXIONID
     1
     3
     4

but i need it as in a single recordset..

XML

COMPLEXIONID
     1
     3
     4

i dont want in a loop...how to achieve this...

Posted 20-Dec-12 22:23pm

sahmed4

Updated 20-Dec-12 22:48pm

Keith Barrow

v3

Add a Solution

2 solutions

Solution 2

You only have one set of data, your problem is that the select you use to get the data is in the loop, execute this:

SQL

DECLARE @Test VARCHAR(1000), @RecSet VARCHAR(500)
DECLARE @StartingPos INT,@RecPos INT
DECLARE @temptable TABLE(COMPLEXIONID INT)
SET @StartingPos= 1
SET @TEST='1,3,4,'
--SET @Test =(select cmp.complexion1 from customerexpectation cmp where cmp.customerid='4fe6559c-bc93-4d9c-bcb2-013fede7d969')
WHILE 
    @StartingPos<=LEN(@Test)
BEGIN
    SELECT @RecPos = CHARINDEX(',',@Test,@StartingPos)
    SET @RecSet=SUBSTRING(@Test,@StartingPos,@RecPos-@StartingPos)
    PRINT @RecSet
    BEGIN
        INSERT INTO @temptable VALUES(@RecSet)
        SELECT @StartingPos=@RecPos+1
    END
END
SELECT * FROM @temptable

I've moved the select to the last line.

Posted 20-Dec-12 22:47pm

Keith Barrow

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

kanyogendra · Accepted Answer · 2012-12-20T22:42:00

Hi Sahmed,
your Sql Query is Ok, you just need to use select Query outside loop

SQL

alter PROC sp_SplitVal
AS
BEGIN
DECLARE @Test VARCHAR(1000), @RecSet VARCHAR(500)
DECLARE @StartingPos INT,@RecPos INT
DECLARE @temptable TABLE(COMPLEXIONID INT)
SET @StartingPos= 1
SET @TEST='1,3,4,'
--SET @Test =(select cmp.complexion1 from customerexpectation cmp where cmp.customerid='4fe6559c-bc93-4d9c-bcb2-013fede7d969')
WHILE @StartingPos<=LEN(@Test)
BEGIN
SELECT @RecPos = CHARINDEX(',',@Test,@StartingPos)
SET @RecSet=SUBSTRING(@Test,@StartingPos,@RecPos-@StartingPos)
PRINT @RecSet
BEGIN
INSERT INTO @temptable VALUES(@RecSet)
SELECT @StartingPos=@RecPos+1
END
END
SELECT * FROM @temptable
end

Thanks!
Yogendra Dubey