Problem with reversing string

Question

1.00/5 (1 vote)

See more:

This code should be get a string then return reverse that string in output but it has problem I want to know can you check it and say wat should I do ecxatlly,thank u so much.

C#

using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
namespace prog_83_reshteh_method_
{
    class Program
    {
        public void reshteh(string x)
        {
            Console.WriteLine("enter a string");
            string str = Console.ReadLine();
            int y= Convert.ToInt32(str);

            for (int i = str.Length - 1; i >= 0; i--)
            {
                Console.WriteLine(str.Substring(i,1));
            }

        }
        static void Main(string[] args)
        {
            Console.WriteLine("enter a string");
            string str = Console.ReadLine();
            int y = Convert.ToInt32(str);

            Program obj = new Program();
            obj.reshteh(x);

        }
    }
}

Posted 30-May-11 8:55am

shohreh25

Updated 30-May-11 8:59am

Not Active

v2

Add a Solution

Comments

[no name] 30-May-11 15:00pm

The subject line is for a short description, not for the question. I've edited this for you.

shohreh25 30-May-11 15:07pm

thank u

[no name] 30-May-11 15:02pm

And what problem does it have? You need to give complete details if you expect answers

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Keith Barrow · Answer 1 · 2011-05-30T09:17:00

Consider using an extension method[^] on the string called Reverse(), if you are using .net 3.5 or above. If below 3.5 create a method string Reverse(string original) {...}
As for the alogrithm "my string"[1] returns the character 'y'. So all you have to do is to iterate over the array, if you iterate forwards you need to fill the built string backwards and vice versa.
How you build the string is up to you, you could use a StringBuilder or just add to an existing string or even create an reversed array of char and create a string from that, depends what you need.

fjdiewornncalwe · Answer 2 · 2011-05-30T09:05:00

There are many things wrong here.

1) Duplicate code: If you want your reshteh method to work using the "x" argument, then remove the following code block from the reshteh method and update the for block to use the x variable instead of the str variable.

C#

Console.WriteLine("enter a string");
string str = Console.ReadLine();
int y= Convert.ToInt32(str);

for( int i = x.Length -1; i >= 0; i-- ) ...

Not Active · Answer 3 · 2011-05-30T09:08:00

Solution 2

A string is simply an array of characters, there is no need to use SubString for this.

C#

public void reshteh(string x)
{
  Console.WriteLine("enter a string");
  string str = Console.ReadLine();

  for (int i = str.Length; i >= 0; i--)
  {
    Console.WriteLine(str[i]);
  }

}

Posted 30-May-11 9:08am

Not Active

Problem with reversing string

3 solutions

Solution 3

Solution 1

Solution 2

Add your solution here

Preview 0