I got error syntax error in update statement, what is the wrong with the code ?

Question

0.00/5 (No votes)

See more:

'Updating AdjustmentHead & AdjustmentDetails
'-------------------------------------------

'update AdjustmentHead
strSql = "UPDATE AdjustmentHead SET AdjustmentHead.[Adjustment+V] = " & Forms![AdjustmentHead]![Adjustment+V] & ", AdjustmentHead.[Adjustment-V] = " & [Forms]![AdjustmentHead]![Adjustment-V2] & ", AdjustmentHead.AdjustmentStatus = -1, AdjustmentHead.AdjTransactionID = " & intTransactionID & ", AdjustmentHead.AdjOrderID = '" & strOrderID & "'"
strSql = strSql & " WHERE (((AdjustmentHead.AdjustmentHeadID)=[Forms]![AdjustmentHead]![AdjustmentHeadID]));"
DoCmd.RunSQL strSql

'update Adjustment
strSql = "UPDATE AdjustmentDetailsQ INNER JOIN Items ON AdjustmentDetailsQ.ItemID = Items.ItemID SET Items.[In] = [Items]![In]+[AdjustmentDetailsQ]![OrderQty], Items.Out = [Items]![Out]+[AdjustmentDetailsQ]![IssueForLocal]+[AdjustmentDetailsQ]![IssueForForign], Items.CIN = [Items]![CIN]+[AdjustmentDetailsQ]![OrderCQty], Items.COut = [Items]![COut]+[AdjustmentDetailsQ]![IssueForLocal]"
strSql = strSql & " WHERE (((AdjustmentDetailsQ.AdjustmentHeadID)=[Forms]![AdjustmentHead]![AdjustmentHeadID]) AND ((AdjustmentDetailsQ.ActQOnH) Is Not Null));"
DoCmd.RunSQL strSql

strSql = "UPDATE Orders SET Orders.Adj = -1"
strSql = strSql & " WHERE (((Orders.OrderID) Like 'adj*'));"
DoCmd.RunSQL strSql

strSql = "UPDATE Transactions SET Transactions.AdjTrans = -1"
strSql = strSql & " WHERE (((Transactions.TransactionNo) Like '*Adj*'));"
DoCmd.RunSQL strSql

'Closing Form

DoCmd.Close

Posted 8-Jun-15 0:35am

MOUTAZ877

Add a Solution

Comments

Richard Deeming 8-Jun-15 6:47am

Your code is vulnerable to SQL Injection[^].

NEVER use string concatenation to build a SQL query. ALWAYS use a parameterized query.

MOUTAZ877 8-Jun-15 7:03am

I did not get your point , it was running fines then it stopped

what shall i do to fix it ?

[no name] 8-Jun-15 7:06am

"what shall i do to fix it ?", use proper parameterized queries just like Richard said.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

ZurdoDev · Answer 1 · 2015-06-08T02:19:00

It looks like you might need quotes around some of your values, however, do not try to fix the code you have. Please change the code you have to use parameters so that you are doing it correctly.

For example:

C#

String sql = "UPDATE table1 SET field1=@field1, field2=@field2...
...
cmd.Parameters.AddWithValue("@field1", txtField1.Text);
cmd.Parameters.AddWithValue("@field2", txtField2.Text);
...

Once you have done it this way your syntax issue will be gone too.