A simple sql question and error

Question

0.00/5 (No votes)

See more:

This code gives me error when i try to execute

SQL

Create Proc spIsPasswordResetLinkValid
@GUID uniqueidentifier
as
Begin
   If(Exists(Select UserId from tblResetPasswordRequests where Id =@GUID)   
   Begin 
     Select 1 as IsValidPasswordresetLink
   End
   Else
   Begin
      Select 0 as IsValidPasswordResetLink
   End
End

The error it gives

Msg 156, Level 15, State 1, Procedure spIsPasswordResetLinkValid, Line 7
Incorrect syntax near the keyword 'Begin'.

Msg 156, Level 15, State 1, Procedure spIsPasswordResetLinkValid, Line 10
Incorrect syntax near the keyword 'Else'.

I dont know whats the error. Can someone point me to right direction.

Posted 3-May-15 1:32am

ankur1163

Updated 3-May-15 2:02am

Tomas Takac

v2

Add a Solution

2 solutions

Solution 3

You are missing a bracket here

C#

If(Exists(Select UserId from tblResetPasswordRequests where Id =@GUID)

Try adding an end braket like

C#

If(Exists(Select UserId from tblResetPasswordRequests where Id =@GUID))

Hope, it helps :)

Posted 3-May-15 2:06am

Suvendu Shekhar Giri

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Tomas Takac · Accepted Answer · 2015-05-03T02:02:00

Solution 2

Parenthesis do not match. Try this:

SQL

If Exists(Select UserId from tblResetPasswordRequests where Id =@GUID)

Edit
It occurs to me that your code is too procedural. It's better you avoid that with SQL. Moreover having logic in database is usually not recommended. You should simply query the data e.g.:

SQL

Select count(UserId) from tblResetPasswordRequests where Id =@GUID

and then evaluate the result in your application.

Posted 3-May-15 2:02am

Tomas Takac

Updated 3-May-15 2:11am

v2

Comments

ankur1163 3-May-15 8:07am

I added @GUID))

One more parenthesis in the end and it worked. Thanks

Suvendu Shekhar Giri 3-May-15 8:07am

Correct. +5