How do I send an automated email from sql with data that is dynamically generated

Question

0.00/5 (No votes)

See more:

Hi All,

I have an SP which sends password recovery email to certain accounts. To implement the same I have to attach to the body, a variable which will be picked from the database and CANNOT be hardcoded. Please suggest ways to do the same.

PFB the sp I am using,

SQL

CREATE PROCEDURE [dbo].[spGetPassword](
@Username Varchar(50))
AS
BEGIN

DECLARE @Password Varchar(100)
DECLARE @RecEmail Varchar(100)
Select @Password=[Password] From [dbo].[LoginDetails] Where [UserName]=@Username

--For sending emails
Select @RecEmail= Value FROM MemberDetails WHERE EmpName=@Username AND Name='Email'
execute msdb.dbo.sp_send_dbmail
@profile_name='*******',@recipients=@RecEmail,--@copy_recipients =@CopyEmail,
@subject= 'Password Recovery', <b<big>>@body= 'Hi, Your password is',@query='Select Password Where Username=@Username'</big>

END

It is working fine but the query bit is not executing, maybe, because I am doing it wrong...Please suggest ways to successfully implement the same.

Thanks

Posted 16-Mar-15 2:15am

Shivangi_K

Add a Solution

Comments

Richard Deeming 16-Mar-15 10:42am

You appear to be storing passwords in plain text. That is a terrible idea. You should only ever store a salted hash of the password.

Secure Password Authentication Explained Simply[^]
Salted Password Hashing - Doing it Right[^]

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

John C Rayan · Accepted Answer · 2015-03-16T03:45:00

Try this. The problem with your query is that @username local variable wont be available in the @query because it is being executed in separate session. You have already got the password in @Password so I am using it in your send mail.

SQL

CREATE PROCEDURE [dbo].[spGetPassword](
@Username Varchar(50))
AS
BEGIN

DECLARE @Password Varchar(100)
DECLARE @RecEmail Varchar(100)
DECLARE @bodyMsg nvarchar(max)
Select @Password=[Password] From [dbo].[LoginDetails] Where [UserName]=@Username
set @bodyMsg = 'Hi, Your password is' + @Password

--For sending emails
Select @RecEmail= Value FROM MemberDetails WHERE EmpName=@Username AND Name='Email'

execute msdb.dbo.sp_send_dbmail
@profile_name='*******',
@recipients=@RecEmail,
@subject= 'Password Recovery',
@body = @bodyMsg

END