How do I correct syntax error in update statement. At cmd.ExecuteNonQuery

Question

0.00/5 (No votes)

See more:

Private Sub Button6_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles Button6.Click
connect.ConnectionString = "Provider=Microsoft.jet.OLEDB.4.0; data source = |datadirectory|/Lecture1.mdb"
connect.Open()
Dim cmd As OleDb.OleDbCommand = New OleDb.OleDbCommand("Select * FROM StudentInfo", connect)
sql = "update Lecture1 set age = ' " & TextBox5.Text & " ' , Gender=' " & TextBox4.Text & " ' , Scourse ='" & TextBox3.Text & "', Sname ='" & TextBox2.Text & "' , where Srec='" & TextBox1.Text & " ' "
cmd = New OleDb.OleDbCommand(sql, connect)
cmd.ExecuteNonQuery()
connect.Close()
MsgBox("Updated")

Posted 11-Mar-15 5:28am

Member 11516719

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

ZurdoDev · Answer 1 · 2015-03-11T05:38:00

You never want to write code like this because your database can be damaged and/or hijacked by sql injection.

Instead please use code similar to:

C#

sql = "UPDATE Lecture1 SET age = @age, Gender = @Gender..."
cmd.Parameters.AddWithValue("@age", TextBox5.Text);
cmd.Parameters.AddWithValue("@Gender", TextBox4.Text);
...

Also, do not leave the default control ids. Having all your textboxes named TextBoxx makes debugging much harder. It's very quick and easy to give them meaningful IDs: txtAge, txtGender. You'll thank yourself later on.