how I can generate Properly html tag with javaScript ?

Question

1.00/5 (1 vote)

See more:

Hi
I Create this code for replace something and show a button :

JavaScript

var text = $(item).html().replace(exp, "<button onclick='alert('hi')' id='btnac' href='$1' >Click to Accept Voice Chat</button>");

But in page I get this and I cant show alert on any function :

XML

<button onclick="alert(" hi')'="" id="btnac" href="www.example.com">Click to Accept Voice Chat</button>

Posted 10-Jan-15 23:27pm

‫محم د‬‎

Updated 10-Jan-15 23:38pm

v3

Add a Solution

Comments

Kornfeld Eliyahu Peter 11-Jan-15 5:32am

And? what went wrong?

‫محم د‬‎ 11-Jan-15 5:36am

Excuse me ! Completed

Kornfeld Eliyahu Peter 11-Jan-15 5:39am

I can see some syntax errors around the alert - wrongly mixed double- and single-quotes? Please check it...

‫محم د‬‎ 11-Jan-15 5:43am

I can see it ! But How I can solve it ? I just use single quotes !

Kornfeld Eliyahu Peter 11-Jan-15 5:57am

Try this:
<button onclick='alert(\"hi\")' id='btnac' href='$1'>Click to Accept Voice Chat</button>

Zoltán Zörgő 11-Jan-15 6:46am

Alrough escaping will work, as you already use jquery, you can (should) use it's DOM manipulation routines instead of adding text.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sergey Alexandrovich Kryukov · Answer 1 · 2015-01-11T07:55:00

Instead of onclick="alert(" hi')'="", it should be onclick="alert('hi')". Anyway, 1) using alert in production is a bad idea, 2) alert doesn't provide a way for user confirmation.

Better use, for example, jQuery dialog: http://jqueryui.com/dialog[^].

DOM manipulation also should be done more accurately. Even if yours works, it makes the functionality poorly supportable, because it depends too much on existing content and your exp. It would be more reliable to take a node found by its order, remove it, and replace what you need (I don't know why though). Please refer to http://api.jquery.com/category/manipulation[^].

—SA