C# Beginner problem

Question

2.00/5 (1 vote)

See more:

The problem is if I enter 0,The instuctions appear but when I exit them,I find out that the value has entered Invalid also.I do not want that.What am I doing wrong and what should I do?

C#

Console.WriteLine("Choose what type of attack");
           decisiontr = Console.ReadLine();
           if (decisiontr == "1" || decisiontr == "2" || decisiontr == "3" || decisiontr == "4" || decisiontr == "5" || decisiontr == "6" ||
               decisiontr == "7" || decisiontr == "8" || decisiontr == "9")
           {
               decision = int.Parse(decisiontr);
           }
           else if (decisiontr == "0")
           { instructions(); }
           if (decisiontr != "1" && decisiontr != "2" && decisiontr != "3" && decisiontr != "4" &&
                   decisiontr != "5" && decisiontr != "6" && decisiontr != "7" && decisiontr != "8" && decisiontr != "9" && decisiontr!="0")
           { HeroATTAX.Invalid(); }
           Console.Clear();
           HeroATTAX attack = new HeroATTAX();

Posted 11-Aug-14 5:59am

swapnil999

Add a Solution

Comments

[no name] 11-Aug-14 12:08pm

What is decisiontr after you return from instructions()?

swapnil999 11-Aug-14 12:21pm

It's the same.
I only press enter.

Dilan Shaminda 11-Aug-14 12:30pm

your code works fine.Just check whether you are assigning some value to decisiontr variable inside your instroctions() funtion

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sergey Alexandrovich Kryukov · Answer 1 · 2014-08-11T06:37:00

What you are doing wrong? You write code in a monstrous, inaccurate way, hard-code immediate constants and don't use the debugger to solve your simple problem. You also give bad names to variables.

For example, your first condition could look better:

C#

const byte decisionMin = 1;
const byte decisionMax = 9;

//...

string decisionInput = Console.ReadLine();
byte decision;
if (!byte.TryParse(out decision))
   return; // or do something else, say, ask to repeat input
if (decisionMin <= decision && decision <= decisionMax)
   //...

And so on…

Just write everything 1) accurately; 2) using your brain; 3) understanding what you are doing in every line; and you will get your results. In even the slightest concerns about your runtime, always use the debugger.

—SA