c# - Problem with getter and setter

Question

0.00/5 (No votes)

See more:

Hello everyone,

I have a problem with my Code. Some classes shouldn't be possible to write in propertys but some classes should be able to write and read them.

Problem in detail:
I coded the invoice in the Controller as private set, so i can only set the invoice in this class. that is what i want.
I also want that i can set the properties of the model in the controller, but not in the view.
But if i set the properties not public in the model, i cant set the properties in the controller too.

I have got 4 classes they looks like the model-view-controller:

Models:

C#

namespace payOffice.Model
{
    class InvoicePosition
    {
        public string Name { get; set; }
        public double Price { get; set; }
    }
}

C#

namespace payOffice.Model
{
    class Invoice
    {
        public List<InvoicePosition> Positions { get; set; }
        public string Consumer { get; set; }
        public bool Completed { get; set; }
        public int InvoiceNumber { get; set; }

        public Invoice(string consumer)
        {
            Consumer = consumer;
        }
    }
}

Controller:

C#

namespace payOffice.Controller
{
    class InvoiceManager
    {
        public Invoice loadedInvoice {get;private set;}

        public InvoiceManager(...){...}

        public void addInvoicePosition(...)
        {
            //here it should be possible:
            loadedInvoice.Positions.Add(...);
        }
    }
}

View:

C#

namespace payOffice.View
{
    public partial class MyView : Form
    {
        InvoiceManager invoiceManager;
        public MyView()
        {
            InitializeComponent();
        }

        public void addInvoicePosition(...)
        {
            //its right so:
            invoiceManager.addInvoicePosition(...);

            //that shouldn't be possible!!!:
            invoiceManager.loadedInvoice.Positions.Add(...);

            //but that should be possible in other methods:
            Console.WriteLine(invoiceManager.loadedInvoice.Consumer);
            //and this should be possible in other methods too
            Console.WriteLine(invoiceManager.loadedInvoice.Positions[0].Price);
        }

    }
}

Did someone have an idea how i can make this possible?

Posted 31-Jul-14 22:28pm

Member 10401272

Updated 31-Jul-14 23:47pm

v3

Add a Solution

Comments

Kumarbs 1-Aug-14 4:49am

You used private setter, i think that is the problem. Ensure that.

Member 10401272 1-Aug-14 4:55am

I see that my problem isn't clear. i improved the question and added a detailed question.

Philippe Mori 2-Aug-14 8:22am

If you don't want to allows properties to be modified, the best solution is to have private set and use constructor (or static method) to initialize all fields from parameters.

That way, properties can only be set at construction time (similar to DateTime or string classes in .NET).

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2014-07-31T22:52:00

At the moment, all of your properties are public - which means anyone can use them if they know teh class exists.

But that's OK, because all your classes are independent, in different namespaces, and nothing is derived from anything else.
So even using protected or internal modifiers on your properties won't help, because the namespaces and lack of derivation mean there are effectively private anyway.

Basically, with the structure you have, you can't prevent any classes from accessing properties if any classes can.

You need to take a step back, look at what you are trying to do, and consider a better class structure (heck - any class structure) and / or better encapsulation to restrict access.

With what you have designed so far, they really isn't anything you can do.

Ziee-M · Answer 2 · 2014-07-31T22:52:00

C#

hi, you have to remove either the setter or the getter.

class InvoicePosition
    {
        private string name { get; set; }    //switch the visibility to private, and the name //start with lowerCase 
//same with this variable
        private double price { get; set; }   //same here

//you can use a property named : [Name] to accecs your var [name]
 public string Name
        {
            get { return name; } // this ligne allow you to read the value
            set { name = value; } //// this ligne allow you to write into the variable
        }
 public double Price  
        {
            get { return price; }
        }
// => Price is only accescable for read.

    }




}

if you work with VS, then encapsualte and the code will be generated.

Hope it helps.

c# - Problem with getter and setter

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0