Is there better way to do this?

Question

0.00/5 (No votes)

See more:

Hey guys, am quite new in programming and this is my first time using "While/Do While".

this is mine code:

VB

If My.Computer.Network.IsAvailable = False Then
           'do nothing
           While My.Computer.Network.IsAvailable = False
               Label1.Text = ("Internet Down")
               Do While My.Computer.Network.IsAvailable = True
                  MsgBox("Internet Back UP")
               Loop
           End While
       End If

That code should tell me when i get disconnected from internet and when internet is up again, but i don't want it to constantly showing msgbox. So my question is how do i make it stop showing msgbox after i click ok and is there better way to do this?

Posted 27-Jul-14 9:52am

DeadlyNoodle

Add a Solution

Comments

PIEBALDconsult 27-Jul-14 16:54pm

You mean other than using a better language? :D

DeadlyNoodle 27-Jul-14 23:57pm

I am not sure do you judge my English or you meant to say better programming language, if so i would go back to school if i wanted review of English knowledge. If you meant on better programming language well i am just a beginner..

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

CPallini · Answer 1 · 2014-07-27T10:20:00

Solution 1

If I got you, you should display a message box only when a change of state happens, that is whenever IsAvailable changes from False to True (or the opposite). In order to do that, you have to store last IsAvailable value and compare it with the current one: if they are equal then do nothing; on the other hand, if they are different then show a message box. Something similar to:

VB

While True
  if My.Computer.Network.IsAvailable <> lastIsAvailable then
    lastIsAvailable = My.Computer.Network.IsAvailable 'update last IsAvailable value
    if lastIsAvailable then
      MsgBox("Internet Back UP")
    Else
      MsgBox("Internet DOWN")
    End If
  End If
  ' execute other, possibly useful, statements
End While

Posted 27-Jul-14 10:20am

CPallini

Updated 27-Jul-14 10:21am

v2

Comments

PIEBALDconsult 27-Jul-14 16:52pm

I don't like the two ifs and two checks of IsAvailable, but at least you eliminated a while.

Sergey Alexandrovich Kryukov 27-Jul-14 17:05pm

Agree. I also don't like the whole idea of showing a message box repeatedly in a loop. This is OP's idea, but at least it should be noted.
—SA

CPallini 27-Jul-14 17:40pm

Well, the checks are different.

Sergey Alexandrovich Kryukov 27-Jul-14 17:05pm

This time, a 4. :-)
—SA

CPallini 27-Jul-14 17:41pm

Thank you.

DeadlyNoodle 27-Jul-14 19:58pm

nah, you didn't get me, i don't want to display msgbox when true/false change, what i wan't is to make program do something when internet is back up from disconnection. hope i were more clear now :)

Sergey Alexandrovich Kryukov 27-Jul-14 21:34pm

More exactly, this is not that we did not get it, this is that you did not express your clearly. Your question seemed to be focused on the loops. Anyway, again, from your last comment it's not clear if you need some further help or not, and if you need it, what exactly would you expect.
—SA

DeadlyNoodle 28-Jul-14 0:10am

Yeah, sorry about that, i do need additional help, so let me try again. What i want is program that monitors my connection, while my internet is up and program is running it should do nothing, when i get disconnection from the internet again it should do nothing(or just label "Internet down"), but i actually want it to automatically run some autohotkey script after internet is up again after disconnection. I am making auto login program for game i am playing. Thanks for your patience.

Daniele Rota Nodari · Answer 2 · 2014-07-27T10:20:00

You can subscribe to the event associated with the IsAvailable property.
Subscribing the event you would receive notification every time the value of IsAvailable property changes.

You will not need to loop and consume CPU cycles.

You can write something like:

VB

Private Sub DisplayAvailability(ByVal available As Boolean, ByVal notify As Boolean)
    If available Then
        Label1.Text = ("Internet Up")
        If notify Then 
            MsgBox("Internet Back UP")
        End If
    Else
        Label1.Text = ("Internet Down")
        If notify Then 
            MsgBox("Internet DOWN")
        End If
    End If
End Sub 

Private Sub MyComputerNetwork_NetworkAvailabilityChanged( _
    ByVal sender As Object, _
    ByVal e As Devices.NetworkAvailableEventArgs)

    DisplayAvailability(e.IsNetworkAvailable, True)
End Sub 

Private Sub Handle_NetworkAvailabilityChanged()
    DisplayAvailability(My.Computer.Network.IsAvailable, False)

    AddHandler My.Computer.Network.NetworkAvailabilityChanged, _
       AddressOf MyComputerNetwork_NetworkAvailabilityChanged
End Sub

...
...

Private Sub Init()
    Handle_NetworkAvailabilityChanged()
End Sub

For more information (and the original example) you can look at My.Computer.Network.NetworkAvailabilityChanged Event[^].

Regards,
Daniele.

PIEBALDconsult · Answer 3 · 2014-07-27T11:40:00

Are you a fan of obfuscation?

C#

int state = 0 ;

for(;;)
{
    switch ( state = ( ( state << 1 ) | System.Net.NetworkInformation.NetworkInterface.GetIsNetworkAvailable().GetHashCode() ) & 3 )
    {
        case 1 : break ; /* Has become true  */ 
        case 2 : break ; /* Has become false */ 
    }

    System.Threading.Thread.Sleep ( 1000 ) ;
}

Is there better way to do this?

3 solutions

Solution 1

Solution 2

Solution 3

Add your solution here

Preview 0