Improve stack implementation

Question

4.00/5 (1 vote)

See more:

Hi,

I just wrote the code for a stack implementation. Any suggestion for the improvement of code is most welcome.

// StackTest.cpp : Defines the entry point for the console application.
//
#include "stdafx.h"
#include<iostream>
using namespace std;

class CStack
{
public:
	int data;
	CStack* ptr;
public:
	void Push();
	void Pop();
	void Display();
};
CStack *ptrTop = NULL;
/* */
void CStack::Display()
{
	CStack *ptrTopClone = ptrTop;
	while(ptrTopClone != NULL)
	{
		cout<<ptrTopClone->data<<endl;
		ptrTopClone = ptrTopClone->ptr;
	}
}
/* */
void CStack::Push()
{
	CStack *newData  = new CStack;
	cout<<"Please enter the data"<<endl<<endl;
	cin>>newData->data;
	newData->ptr =( ptrTop == NULL)? NULL: ptrTop;
	ptrTop = newData;
}

/* */
void CStack::Pop()
{
	if( ptrTop == NULL)
		cout<<"Stack is empty"<<endl<<endl;
	else
	{
		CStack *ptrPrevNode = ptrTop;
		ptrTop = ptrPrevNode->ptr;
		cout<<"*********"<<endl;
		cout<<"Deleted Item is:"<<ptrPrevNode->data<<endl<<endl;
		cout<<"*********"<<endl;
		delete ptrPrevNode;
		ptrPrevNode = NULL;//its better to set to NULL
	}
}
/* */
int _tmain(int argc, _TCHAR* argv[])
{
	int choice;
	CStack *ptrStackImp = new CStack;
		do
		{
			cout<<"*********"<<endl;
			cout<<"1.PUSH"<<endl;
			cout<<"2.POP"<<endl;
			cout<<"3.DISPLAY"<<endl;
			cout<<"0.EXIT"<<endl;
			cin>>choice;
			cout<<"*********"<<endl;
			switch(choice)
			{
			case 1:
				ptrStackImp->Push();
				break;
			case 2:
			ptrStackImp->Pop();
				break;
			case 3:
				ptrStackImp->Display();
				break;			
			}
		
		}while(choice!=0);
	delete ptrStackImp;
	ptrStackImp = NULL;
	return 0;
}

Posted 6-May-10 19:41pm

Saurabh_Saxena

Updated 6-May-10 21:15pm

Moak

v2

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

CPallini · Accepted Answer · 2010-05-06T21:13:00

Solution 2

I would put I/O out of your class, i.e. the signature of Push and Pop methods should be (IMHO):

void Push( int i);// you may also choose a int return value (new stack size)
int Pop();

:)

Posted 6-May-10 21:13pm

CPallini

Sauro Viti · Accepted Answer · 2010-05-06T20:41:00

First make the methods Push, Pop and Display static; then make the variable ptrTop a private static field of the class and the field ptr a private field:

C++

class CStack
{
public:
   int data;

private:
   static CStack* ptrTop;
   CStack* ptr;

public:
   static void Push();
   static void Pop();
   static void Display();
};

CStack* CStack::ptrTop = NULL;

This way you'll have the advantages below:

you don't need to instantiate a CStack object to call the Push, Pop and Display methods

the ptr and ptrTop variables are protected from being accessed and modified outside the CStack class code