How Do I Update Multiple Rows Using Split Function And While Loop In Sqlserver ?

Question

0.00/5 (No votes)

See more:

SQL-Server-2008R2

I am using this code but its not working,it just update only one value.I want to update mulitple rows with different values

SQL

USE [DB_QSO_Updated]
GO
/****** Object:  UserDefinedFunction [dbo].[Split]    Script Date: 06/23/2014 13:44:39 ******/
SET ANSI_NULLS ON
GO
SET QUOTED_IDENTIFIER ON
GO
ALTER FUNCTION [dbo].[Split]
(
	@List nvarchar(2000),
	@SplitOn nvarchar(5)
)  
RETURNS @RtnValue table 
(
		
	Id int identity(1,1),
	Value nvarchar(100)
) 
AS  
BEGIN
While (Charindex(@SplitOn,@List)>0)
Begin
Insert Into @RtnValue (value)
Select 
    Value = ltrim(rtrim(Substring(@List,1,Charindex(@SplitOn,@List)-1)))
    Set @List = Substring(@List,Charindex(@SplitOn,@List)+len(@SplitOn),len(@List))
End
 Insert Into @RtnValue (Value)
    Select Value = ltrim(rtrim(@List))

    Return
END

use in store procedue:

SQL

select * from dbo.Split(@RunTimeValue,',')

Posted 22-Jun-14 22:19pm

Pardeep Rajput

Updated 22-Jun-14 22:23pm

DamithSL

v2

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2014-06-22T22:55:00

Probably, it's your insert statement:

SQL

Insert Into @RtnValue (value)

Since you don't specify the columns, it will try to insert your value into the first column - which is identity - and fail because:
1) You can't write to an an Identity column
and
2) You can't write a null into your Value column.

Try specifying the columns:

SQL

INSERT INTO @RtnValue (Value) VALUES (value)

Or see here: Converting comma separated data in a column to rows for selection[^] which does much the same thing.