Parameters in WHERE clause

Question

0.00/5 (No votes)

See more:

SQL-Server-2008R2

Hi i have the following stored procedure which will accept 2 params. The first is @CUSTNAME and the second is @YEAR. @CUSTNAME works fine but @YEAR have an error. Below are my codes:

SQL

DECLARE @SQL NVARCHAR(MAX)
DECLARE @params NVARCHAR(MAX)

SELECT @SQL = 'SELECT CustomerName,[0] as Pending, [1] as Save_As_Draft, [2] as Spec_Confirmed, [3] as Request_Revision, [4] as Withdraw, [5] as Pending_RND, [6] as Pending_QC, [7] as Manday_Confirmed, [0]+[1]+[2]+[3]+[4]+[5]+[6]+[7] as Total
FROM
(
    SELECT P.DocStatus,C.CustomerName,P.CustomerID
    FROM dbo.CRF_Project P
    INNER JOIN dbo.CustomerList C
    ON P.CustomerID = C.CustomerID
) p

PIVOT
(
    COUNT (CustomerID) FOR DocStatus IN ([0], [1], [2], [3], [4], [5], [6], [7])

) AS pvt '

SELECT @params = '@CUSTNAME VARCHAR(MAX),
                  @YEAR VARCHAR(MAX)'

IF(@CUSTNAME != '' AND @YEAR = '')
    SELECT @SQL = @SQL + ' WHERE CustomerName IN (' + @CUSTNAME + ')'
ELSE IF(@CUSTNAME = '' AND @YEAR != '')
    SELECT @SQL = @SQL + ' WHERE Year([CreateDate])= (' +@YEAR+ ')' --<--error here
ELSE
    SELECT @SQL = @SQL

EXEC sp_executesql @SQL, @params, @CUSTNAME, @YEAR
END

every time i execute the stored procedure ,it will give me the following error message:
Incorrect column name 'CreateDate'.

My input is for @CUSTNAME 'Osm' and @YEAR '2014'

Posted 17-Jun-14 17:56pm

Jamie888

Updated 17-Jun-14 21:10pm

v2

Add a Solution

Comments

Kornfeld Eliyahu Peter 18-Jun-14 3:30am

It as simple as it sounds, there is no such column CreateDate in your query!
You probably missed some data or picked up the wrong column name...

Jamie888 18-Jun-14 3:35am

i have checked it many times, but there is CreateDate in my table. If i put the where clause inside the pivot after the ON P.CustomerID = C.CustomerID, it is ok but it is not what it should be.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Kornfeld Eliyahu Peter · Accepted Answer · 2014-06-17T21:40:00

Quote:
but there is CreateDate in my table

In the table there is but the query hides the table. You use FROM (sub-query) from instead of FROM [table-name]. In this case the only columns in the sub-query accessible in the where clause and not all the columns in the table...
You may change it like this

SQL

FROM
(
    SELECT P.DocStatus,C.CustomerName,P.CustomerID, CreateDate
    FROM dbo.CRF_Project P
    INNER JOIN dbo.CustomerList C
    ON P.CustomerID = C.CustomerID
) p

UPDATE according OPs comments...

SQL

FROM
(
    SELECT P.DocStatus,C.CustomerName,P.CustomerID
    FROM dbo.CRF_Project P
    INNER JOIN dbo.CustomerList C
    ON P.CustomerID = C.CustomerID
    WHERE Year([CreateDate])= (' +@YEAR+ ')'
) p

And

SQL

IF(@CUSTNAME != '' AND @YEAR = '')
    SELECT @SQL = @SQL + ' WHERE CustomerName IN (' + @CUSTNAME + ')'
ELSE IF(@CUSTNAME = '' AND @YEAR != '')
    SELECT @SQL = @SQL + ' WHERE Year([CreateDate])= (' +@YEAR+ ')' --<--error here
ELSE
    SELECT @SQL = @SQL