How Can I Have Two Queries In One Data Reader Or Help Or Help Me Out With A Solution

Question

0.00/5 (No votes)

See more:

C#

con = new SqlConnection(connetionString); 
           try
           {
               con.Open();
               cmd = new SqlCommand(sql, con);// SELECT query has been invoked in Sql
               cmd.ExecuteReader();
               cmd.Dispose();
               con.Close();
               con.Open();
               sql1 = "INSERT INTO Features(Feature_Project_id, Feature_Project_Name, Feature_Description) VALUES ('"+cmd+"', '" + s + "','" + textBox1.Text + "')";
               cmd = new SqlCommand(sql1, con);
               cmd.ExecuteNonQuery();
               cmd.Dispose();
               con.Close();
               MessageBox.Show (" ExecuteNonQuery in SqlCommand executed !!");
           }
           catch (Exception er)
           {
               MessageBox.Show(er.Message);
           }
       }


//Please help me out with a solution

Posted 20-Apr-14 22:36pm

R.BinayRam

Add a Solution

Comments

syed shanu 21-Apr-14 4:38am

Here where do you have 2 query.I can see only one query.if you want to execute more then one query.Create a stored procedure and in SP you can write your select,insert and update query.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2014-04-20T22:48:00

That code is...um...odd.
You create a command (which is commented as a SELECT), execute it, but throw away the results, and then dispose of it, and close the connection.
Then you try to do an INSERT operation...which presumably is giving you a problem.

The SELECT code does nothing useful: so get rid of it.

C#

    con = new SqlConnection(connetionString);
    try
    {
        con.Open();
        sql1 = "INSERT INTO Features(Feature_Project_id, Feature_Project_Name, Feature_Description) VALUES ('"+cmd+"', '" + s + "','" + textBox1.Text + "')";
        cmd = new SqlCommand(sql1, con);
        cmd.ExecuteNonQuery();
        cmd.Dispose();
        con.Close();
        MessageBox.Show (" ExecuteNonQuery in SqlCommand executed !!");
    }
    catch (Exception er)
    {
        MessageBox.Show(er.Message);
    }
}

And your INSERT may start to work.
But... don't do it like that! Do not concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Use Parametrized queries instead.

C#

using (con = new SqlConnection(connetionString))
    {
    try
        {
        con.Open();
        sql1 = "INSERT INTO Features(Feature_Project_id, Feature_Project_Name, Feature_Description) VALUES (@PID, @PNM, @DESC)";
        using (cmd = new SqlCommand(sql1, con))
            {
            cmd.Parameters.AddWithValue("@PID", cmd);
            cmd.Parameters.AddWithValue("@PNM", s);
            cmd.Parameters.AddWithValue("@DESC", textBox1.Text);
            cmd.ExecuteNonQuery();
            }
        MessageBox.Show(" ExecuteNonQuery in SqlCommand executed !!");
        }
    catch (Exception er)
        {
        MessageBox.Show(er.Message);
        }
    }