Skip a Exception (out of index), program hangs after catch

Question

0.00/5 (No votes)

See more: (untagged)

my promgram bugs after the catch and won't run anymore.

anyone know how to skip a out of index? without try; catch?

C#

try
{
    lines2 = ResultViewshown2[i].Split(new string[] { "\r\n", "\n" },    StringSplitOptions.None);

    for (int x = 0; x < 10000; x++)
    {
            string line = lines2[x];

            if (!line.Contains(check2))
            {
                Resultadd2.Add((string.Format("{0}\r\n", line ?? string.Empty)));
            }
    }
}
catch(IndexOutOfRangeException)
{
}

Posted 14-Apr-14 3:27am

Wessel Beulink

Add a Solution

Comments

[no name] 14-Apr-14 9:32am

Why aren't you checking the size of lines2?

Wessel Beulink 14-Apr-14 9:37am

I tried but the index is always 10.000.

still getting error after size check of lines2

[no name] 14-Apr-14 9:48am

You tried what? If the length of lines2 is always 10000 then how are you getting an Index out of range? How do you know when you are simply ignoring the exception?

Wessel Beulink 14-Apr-14 10:02am

because the index is a range of items in a listbox,

i manual copyed 10.000 lines of text in there. i wasn't ingnoring the exeption but it crashed my program.

the IsNullOrEmpty was a good fix for it. still didn't understand my fault.

[no name] 14-Apr-14 10:12am

Well I sure don't know either since what you just said makes no sense to me. And an empty catch block is ignoring the exception.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Manas Bhardwaj · Accepted Answer · 2014-04-14T03:37:00

Solution 1

I would be following more defensive approach. See below:

C#

try
{
    lines2 = ResultViewshown2[i].Split(new string[] { "\r\n", "\n" },    StringSplitOptions.None);

    for (int x = 0; x < lines2.length; x++)
    {
        string line = lines2[x];

        if(!string.IsNullOrEmpty(line))
        {
            if (!line.Contains(check2))
            {
                Resultadd2.Add((string.Format("{0}\r\n", line ?? string.Empty)));
            }
        }
    }
}
catch(IndexOutOfRangeException)
{
    //handle your exception
}

Posted 14-Apr-14 3:37am

Manas Bhardwaj

Updated 14-Apr-14 3:51am

v2

Comments

Richard MacCutchan 14-Apr-14 9:40am

Don't tell people to use empty catch blocks; there is enough bad code being generated as it is.

Manas Bhardwaj 14-Apr-14 9:51am

Thanks.

I didn't even look at it. Fixed now!

Wessel Beulink 14-Apr-14 9:45am

thanks! this help me out, it was an array so .length won't fit in here.

I used a LongLength.

why won't u use a empty catch block Richarc MacCutchan?

Richard MacCutchan 14-Apr-14 9:57am

Using an empty catch block means you catch the error and then throw it away. So your program proceeds quite happily ignoring what could be a fatal error, and you will not discover it until too late. I just hope the people who are doing it that way are not writing code for my bank.

Manas Bhardwaj 14-Apr-14 9:59am

Ditto!

Wessel Beulink 14-Apr-14 10:08am

yes, i can come in that! I'll delete the catch. thanks! Richard & Manas

Richard MacCutchan 14-Apr-14 12:08pm

No, no, NO! Do not delete the catch, that makes it worse. Use the try catch block to help ensure that you know when something goes wrong.

Manas Bhardwaj 14-Apr-14 9:59am

It's a bad practice. Empty catch basically means something went wrong in your code and you just EAT AWAY the error message, stack trace and continue as if nothing happened.

The least you should do in catch block is to log the exception.