problem in string literal.... not taking whitespaces.....

Question

0.00/5 (No votes)

See more:

i have written a code in which it checks that what ever is in ' ' it should display it as a string literal but its not taking white spaces in it. when there is no whitespace in '' then it display it as a string literal
here is my code.............

C#

//string literals
                                      bool startSym = ss.StartsWith("'");
                                      bool endSym = ss.EndsWith("'");
                                      string strr = ss.Substring(1);
                                      bool strliteral = strr.Any(char.IsLetterOrDigit) || strr.Any(char.IsPunctuation) || strr.Any(char.IsSymbol);
                                      bool invalid_str = strr.StartsWith("'") && startSym && strliteral  && endSym;
                                      string strspace = ss;
                                      //bool space = strspace;
                                      //&& strr.Any(char.IsSeparator)
                                      if (startSym  && strliteral && endSym)
                                      {
                                        if (invalid_str)
                                          {
                                              MessageBox.Show("Error: Line num  " + linecount + "  Invalid String Literal b/c of multiple starting symbol");
                                              errorcount++;
                                              break;
                                          }
                                         // if (ss.Length > 2) //valid string literal
                                          else
                                          {
                                              MessageBox.Show("this is a String Literal");
                                              break;
                                          }
                                      }

can any one please help me............

Posted 12-Apr-14 20:04pm

Member 10740412

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2014-04-12T20:21:00

Solution 1

You don't use Any like that: http://msdn.microsoft.com/en-us/library/bb534972(v=vs.90).ASPX[^]
You don't just give a method name!
Try:

C#

bool areThereAnyLetterOrDigitsInStrrAtAll = strr.Any(c => char.IsLetterOrDigit(c));

Posted 12-Apr-14 20:21pm

OriginalGriff

Comments

Member 10740412 13-Apr-14 2:29am

not working still.........

OriginalGriff 13-Apr-14 2:39am

So show us exactly what code you are using now.

OriginalGriff 13-Apr-14 2:53am

And while you are at it, "not working" doesn't help much!
Try showing your input, what you expect and why, and what you actually get - it helps us work out what is wrong. :laugh:

Member 10740412 13-Apr-14 2:59am

'this is my string'
this is the input i am giving and it should be displayed as that it is a string literal but its ignoring white spaces and does not display anything.
but when i use only single word like 'this' without any space it displays it is a string literal...

OriginalGriff 13-Apr-14 3:51am

I just tried your original code, and it "works" for me: it's wrong, in so many ways, but:
string ss = "'this is a string'";
bool startSym = ss.StartsWith("'");
bool endSym = ss.EndsWith("'");
string strr = ss.Substring(1);
bool strliteral = strr.Any(char.IsLetterOrDigit) || strr.Any(char.IsPunctuation) || strr.Any(char.IsSymbol);
bool invalid_str = strr.StartsWith("'") && startSym && strliteral && endSym;
string strspace = ss;
if (startSym && strliteral && endSym)
{
if (invalid_str)
{
MessageBox.Show("Error: Line num Invalid String Literal b/c of multiple starting symbol");
return;
}
else
{
MessageBox.Show("this is a String Literal");
return;
}
}
Gives me the MessageBox "this is a string literal".
So the initial problem is almost certainly that the string isn't what you think it is!

But... it won't work in practice, because Any returns true is any of the conditions is true - so checking is Any character is a letter will pass even if your string is
''''''s'
You want to know if the whole string only contains valid characters, I suspect, which is rather different.
What I would do is:
Check the string starts and ends with a quote.
Then check each character to make sure it is valid - and you would need to list what characters are valid, and I don't know what that list is - and fail the string if any character does *not* match, rather than as you are which passes the string if any character does match.

Out of interest, have you considered using a Regex?

Member 10740412 13-Apr-14 5:13am

i don't know how to use Regex.......

OriginalGriff 13-Apr-14 5:29am

I thought you might not - it's a complex tool, but this is the kind of thing it's designed for. But - it's complex, so I won't try and give you a Regex solution that you won;t stand a chance of understanding: they are very cryptic! :laugh:

So try it manually, as I suggested above.

Member 10740412 13-Apr-14 6:04am

i have tried that but still its not working

OriginalGriff 13-Apr-14 6:12am

That isn't helpful - I can't see your screen!
So tell me exactly what you tried, and how it didn't work.
What did the debugger show you was the input string, and what happened as you step through the code?

Member 10740412 13-Apr-14 6:15am

it only displays when in '' there is a single word but there are many words it didn't work

OriginalGriff 13-Apr-14 6:23am

As I said: when I try your original code - with tiny changes because I'm not using a loop - it does work. (Or at least it gives me the "it's ok" box)
So what are you doing outside that code that might not be doing what you expect?
Have you tried the debugger at all?

Member 10740412 13-Apr-14 11:14am

i tried....
still its not working......

OriginalGriff 13-Apr-14 11:41am

What did the debugger show?

Member 10740412 13-Apr-14 11:47am

the same thing

OriginalGriff 13-Apr-14 12:15pm

You don't know what a debugger is, or how to use it, do you?
*sigh*
The debugger lets you see what you program is doing while it runs - so you can look at exactly what is happening line-by-line and look at exactly what is in a variable before it is used, checked, or changed.

So start by putting a breakpoint at the top of your loop, and run your code until it hits it.
Your code will stop, and wait for you to tell it to continue.
By hovering your mouse over a variable, you can see what it contains. You can then single step your app to follow what it is doing - so work out what each lien should do, and then execute that line. Check what happened. Was it what you expected? Repeat until what happens wasn't what you wanted, and you will get a very, very big clue as to why your code isn't working!
I can't do that for you - I don't have access to your computer. So give it a try...

Member 10740412 13-Apr-14 2:49am

bool startSym = ss.StartsWith("'");
bool endSym = ss.EndsWith("'");
string strr = ss.Substring(1);
bool strliteral = strr.Any(char.IsLetterOrDigit) || strr.Any(char.IsPunctuation) || strr.Any(char.IsSymbol);
// bool invalid_str = strr.StartsWith("'") && startSym && strliteral && endSym;
// string strspace = ss;
bool areThereAnyLetterOrDigitsInStrrAtAll = strr.Any(c => char.IsLetterOrDigit(c));
//bool space = strspace;
//&& strr.Any(char.IsSeparator)
if (startSym && strliteral && endSym)
{
//if (invalid_str)
if(areThereAnyLetterOrDigitsInStrrAtAll)
{
MessageBox.Show("Error: Line num " + linecount + " Invalid String Literal b/c of multiple starting symbol");
errorcount++;
break;
}
// if (ss.Length > 2) //valid string literal
else
{
MessageBox.Show("this is a String Literal");
break;
}
}