Syntax error in date in query expression '#.42'. c# winforms

Question

0.00/5 (No votes)

See more:

Hi,
An trying to update my existing data i used this query but am getting error on

SQL

top.ExecuteNonQuery();

Syntax error in date in query expression '#.42'.
This is my updating sql query

SQL

OleDbCommand top = new OleDbCommand("UPDATE NewInvoice_1 SET Terms ='" + CBL_Terms.EditValue.ToString() + "', 
InvoiceDate='" + CBL_Date.Text + "', 
OurQuote='" + TXE_OurQuote.Text + "', 
SalesPerson='" + CBL_Sales_Person.EditValue.ToString() + "', 
CustomerName='" + CBL_Customer_Name.EditValue.ToString() + "',
OrderNumber='" + TXE_Order_Number.Text + "', 
InvoiceAddress='" + TXE_Invoice_Address.Text + "',
DeliveryAddress=" + TXE_Delivery_Address.Text + ",
WholeDiscountP='" + Convert.ToDecimal(TXE_FlatDiscountP.Text) + "', 
WholeDiscountA='" + Convert.ToDecimal(TXE_FlatDiscountA.Text) + "',
ShippingP='" + Convert.ToDecimal(TXE_ShippingPercentage.Text) + "', 
ShippingA='" + Convert.ToDecimal(TXE_ShippingAmount.Text) + "',
Price='" + Convert.ToDecimal(TXE_SubTotal.Text) + "',
Discount='" + Convert.ToDecimal(TXE_Discount.Text) + "',
Tax='" + Convert.ToDecimal(TXE_Tax.Text) + "', 
Shipping='" + Convert.ToDecimal(TXE_Shipping.Text) + "',
GrandTotal='" + Convert.ToDecimal(TXE_GrandTotal.Text) + "',
TaxforDisc='" + barCheckItem1.Checked + "', 
DiscountType='" + selectedItem + "',
ShippingBy='" + TXE_Shipping_By.Text + "',
ShipReferenceNo=" + TXE_Reference_No.Text + ", 
IsInsured='" + CBX_Is_Insured.Checked + "', 
Notes='" + TXE_Notes.Text + "', 
DueDate='" + CBL_DueDate.Text + "' WHERE InvoiceId=" + TXE_Unvisible.Text, conn);

top.ExecuteNonQuery();

this is my query what was wrong with this query ?? help me.
Thanks in advance
Sri

Posted 22-Mar-14 0:49am

srihari1904

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard MacCutchan · Accepted Answer · 2014-03-22T00:57:00

Just about everything is wrong with it. You are using string concatenation which leaves your system wide open to SQL injection attacks. You are using Convert.ToDecimal inline, with no allowance for invalid entries. You are then trying to concatenate those decimal values into your string. You should use proper parameterised queries and correct representations of each field in your tables.

srihari1904 · Accepted Answer · 2014-03-22T02:01:00

Hi thanks you friends I solved

SQL

OleDbCommand top = new OleDbCommand("UPDATE NewInvoice_1 SET   "+
                "  Terms = "+ CBL_Terms.EditValue.ToString() +",   "+
                "  InvoiceDate='" + CBL_Date.DateTime + "',  "+
                "  OurQuote='" + TXE_OurQuote.Text + "',       "+
                "  SalesPerson=" + CBL_Sales_Person.EditValue.ToString() + ",   "+
                "  CustomerName=" + CBL_Customer_Name.EditValue.ToString() + ",  "+
                "  OrderNumber='" + TXE_Order_Number.Text + "',  "+
                "  InvoiceAddress='" + TXE_Invoice_Address.Text + "',  "+
                "  DeliveryAddress='" + TXE_Delivery_Address.Text + "',       "+
                "  WholeDiscountP=" + Convert.ToDecimal(TXE_FlatDiscountP.Text) + ",        "+
                "  WholeDiscountA=" + Convert.ToDecimal(TXE_FlatDiscountA.Text) + ",      "+
                "  ShippingP=" + Convert.ToDecimal(TXE_ShippingPercentage.Text) + ",       "+
                "  ShippingA=" + Convert.ToDecimal(TXE_ShippingAmount.Text) + ",       "+
                "  Price=" + Convert.ToDecimal(TXE_SubTotal.Text) + ",      "+
                "  Discount=" + Convert.ToDecimal(TXE_Discount.Text) + ",    "+
                "  Tax=" + Convert.ToDecimal(TXE_Tax.Text) + ", "+
                "  Shipping=" + Convert.ToDecimal(TXE_Shipping.Text) + ",    "+
                "  GrandTotal=" + Convert.ToDecimal(TXE_GrandTotal.Text) + ",   "+
                "  TaxforDisc=" + barCheckItem1.Checked + ",   DiscountType='" + selectedItem + "',    "+
                "  ShippingBy='" + TXE_Shipping_By.Text + "',ShipReferenceNo='" + TXE_Reference_No.Text + "',    "+
                "  IsInsured=" + CBX_Is_Insured.Checked + ", Notes='" + TXE_Notes.Text + "',     "+
                "  DueDate='" + CBL_DueDate.Text + "'     "+
                "  WHERE InvoiceId=" + TXE_Unvisible.Text, conn);
            top.ExecuteNonQuery();

Syntax error in date in query expression '#.42'. c# winforms

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0