syntax error Update statement. . . please help me where is the problem. . .this is my college project. . .heres my code

Question

0.00/5 (No votes)

See more:

VB

Try
            Dim SqlQuery As String = "UPDATE CustomerT SET [Contact] ='" & txtcontact.Text & _
                                                                "', [FirstName] ='" & txtfirstname.Text & _
                                                                "', [LastName] ='" & txtlastname.Text & _
                                                                "', [Address] ='" & txtaddress.Text & _
                                                                "', WHERE CustomerID = '" & txtid.Text & ";"
            Dim SqlCommand As New OleDbCommand
            With SqlCommand
                .CommandText = SqlQuery
                .Connection = conn
                .ExecuteNonQuery()
            End With
            loadlistView()
            MsgBox("One Record Successfully Updated. . .")

        Catch ex As Exception
            MsgBox(ex.Message)
        End Try

    End Sub

Posted 9-Mar-14 5:23am

Member 10655667

Updated 9-Mar-14 5:25am

Thomas Daniels

v2

Add a Solution

2 solutions

Solution 3

"', WHERE CustomerID = '" &

just remove the comma before where keyword and it should work.

Posted 9-Mar-14 5:39am

Raj Parashar

Comments

Member 10655667 9-Mar-14 12:18pm

new error sir ... it says "Syntax Error in query expression 'CustomerID = '0;'." <--on the equals number, anything that i take edit in data. .ex. i edit the number 4 the error says "Syntax Error in query expression 'CustomerID = '4;'." and so on. . .im new in vb.net i dont knowwto do

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Thomas Daniels · Accepted Answer · 2014-03-09T05:38:00

You forgot a quote before the semicolon and you shouldn't put a comma before the WHERE keyword. Also, you use string concatenation to create the queries. That's not a good idea, because now you aren't protected against SQL Injection[^]. Use parameterized queries instead. Using parameterized queries also improves the readability and you'll make less syntax errors:

VB

Dim SqlQuery As String = "UPDATE CustomerT SET [Contact] = @Contact, [FirstName] = @FirstName, [Address] = @Address WHERE CustomerID = @ID;"
Dim SqlCommand As New OleDbCommand
With SqlCommand
    .CommandText = SqlQuery
    With .Parameters
        .AddWithValue("@Contact", txtcontact.Text)
        .AddWithValue("@FirstName", txtfirstname.Text)
        .AddWithValue("@LastName", txtlastname.Text)
        .AddWithValue("@Address", txtaddress.Text)
        .AddWithValue("@ID", txtid.Text)
    End With
    .Connection = conn
    .ExecuteNonQuery()
End With