error in query

Question

0.00/5 (No votes)

See more:

I am making an app .. in which there's few table the tables named Month and Expense are having 1 to many realtionship....
when ever I write this query

qry = "INSERT INTO EXPENSE values('" + tb_ID.Text + dtp_Edate.Text + "',#" + dtp_Edate.Value.ToString + "#," + tb_Amount.Text + ", '" + tb_Description.Text + "')" ... the prog shows error ,,, like sometimes ,,, that the values don't match or some times error in INSERT into ....

aaah !NEEd vb.net code.... I don't have too experience ...

Posted 12-Apr-10 9:19am

syed jalal

Updated 13-Apr-10 9:11am

v2

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2010-04-12T09:28:00

Rule one: Don't do that!
Rule two: see rule one.

Replace your query with a parameterized query. It will prevent an SQL injection attack, make your code neater, and almost certainly get rid of your problem to boot.

SqlCommand cmd = new SqlCommand("INSERT INTO Expense (ID, Date, Amount, Description) VALUES (@ID, @DT, @AM, @DS)");
cmd.AddWithValue("@ID", tb_ID.Text);
cmd.AddWithValue("@DT", dtp_Edate.Text);
cmd.AddWithValue("@AM", dtp_Edate.Value.ToString);
cmd.AddWithValue("@DS", tb_Description.Text);