Garbage values are inserting in a texbox , when I click the button 'A'....

Question

2.00/5 (1 vote)

See more:

VS2005

Following is the code for inserting a character 'A' on the edit box. But when I click the button it inserting some garbage values..... I dunno why it is..., I am suspecting some problem with format function.......

Please help me on this......

C#

void CEditBox_1Dlg::OnBnClickedButton1()
{
    // TODO: Add your control notification handler code here



    CString getvalue='\0';
    usCurPos=0;
    char carrArray[50],csTemp[50];
    char *carrptr ;
    carrptr =carrArray;
    char a = 'A';
    //UpdateData(true);
    m_CntrlDisplay.SetFocus();

    m_TxtSamplingFrequency.Insert(usCurPos,a);

    //((CEdit*)GetDlgItem(IDC_EDIT1))->GetWindowTextW(getvalue);
    m_CntrlDisplay.GetWindowText(getvalue);

    strcpy(carrArray,(LPCSTR) (CStringA)getvalue);

    carrptr += usCurPos;


    sprintf(csTemp,"%s",carrptr);

    for(short sLoop = 0;sLoop<strlen((char*)csTemp);sLoop++)

    {

        *carrptr =csTemp[sLoop]; carrptr++;

    }

    *carrptr = '\0';

    getvalue.Format(L"%s",carrArray);



    //((CEdit*)GetDlgItem(IDC_EDIT1))->SetWindowTextW(getvalue);

    m_CntrlDisplay.SetWindowText(getvalue);

    UpdateData(false);
    usCurPos++;
    m_CntrlDisplay.SetSel(usCurPos,usCurPos);

    //m_CntrlDisplay=atoi(carrSamplFreq);
    m_TxtSamplingFrequency = (getvalue);
    UpdateData(false);

}

Posted 22-Dec-13 19:08pm

Baakki

Add a Solution

Comments

Richard MacCutchan 23-Dec-13 4:25am

Step through this code with your debugger and you will soon see what is going on. I suspect there is a lot of redundancy in there.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Jochen Arndt · Accepted Answer · 2013-12-22T22:23:00

Most of your code seems to be useless and the Unicode/char conversion parts are wrong.

The wrong parts that lead to the garbage values are:

// Wrong:
strcpy(carrArray,(LPCSTR) (CStringA)getvalue);
// Correct:
//  Create CString object passing a pointer to perform the conversion
strcpy(carrArray,CStringA(getvalue.GetString()).GetString());

// Wrong: 
getvalue.Format(L"%s",carrArray);
// Correct: 
//  Tell the format function that the string is of type char* using the 'h' prefix
getvalue.Format(L"%hs",carrArray);

There is no need to copy the string multiple times to insert the character at increasing positions. Just use your m_TxtSamplingFrequency variable:

// Get the text
m_CntrlDisplay.GetWindowText(m_TxtSamplingFrequency);
// Check position; append if beyond the end
if (usCurPos > m_TxtSamplingFrequency.GetLength())
    usCurPos = m_TxtSamplingFrequency.GetLength();
// Insert character
m_TxtSamplingFrequency.Insert(usCurPos, _T('A'));
// Set text
m_CntrlDisplay.SetWindowText(m_TxtSamplingFrequency);
// Set selection behind inserted char
usCurPos++;
m_CntrlDisplay.SetSel(usCurPos,usCurPos);