Closing a connection

Question

0.00/5 (No votes)

See more:

This is making me absolutely NUTS!

Why, oh why is closing a connection hanging up my hosting server???

Quick background: I put in code to test every single step by writing out the step to a text file on the server. (All of the text-writing code works fine by the way.)

When I close the connection (as shown below) the site hangs up for about 60 seconds and eventually throws a "connection was reset" page.

Any idea what's going on here??

My code:

VB

' start by verifying that this record is still available first
Dim conn As OleDbConnection = New OleDbConnection(sConnectionString)
Dim cmd As OleDbCommand = New OleDbCommand()
Dim sql As String = "SELECT [Type] FROM [Login] WHERE [UserID] = '" & sUsrID & "'"

Try
	cmd = New OleDbCommand(sql, conn)
	conn.Open()
Catch ex As Exception
	If HandleError(ex, "sql: " & sql) Then Server.Transfer("~/errorhandler.aspx")
End Try

Dim sdr As OleDbDataReader = cmd.ExecuteReader(Data.CommandBehavior.SingleRow)
Dim bFound As Boolean = sdr.Read()
Dim iTyp As Integer
If bFound Then iTyp = sdr("Type")

sdr.Close()
conn.Close()   <--- THIS causes the site to hang up!

' The following code NEVER executes:
errRoutineName = "Register:btnSubmit_Click(2)"

Posted 13-Dec-13 8:16am

Member 10465232

Updated 13-Dec-13 8:37am

fixthebugg

v2

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Ron Beyer · Answer 1 · 2013-12-13T09:02:00

Try wrapping your connection and command objects in Using blocks, see: http://msdn.microsoft.com/en-us/library/ms254507(v=vs.110).aspx?cs-save-lang=1&cs-lang=vb#code-snippet-1[^]

Also, you should probably use ExecuteScalar instead of ExecuteReader, that way you don't have to use a DataReader object. If the ExecuteScalar returns null, then the user is not found, if it doesn't return null, just cast it to your type object.

When using the Using blocks, you don't have to worry about cleaning up the resources, the framework does it for you. I'm not sure why you are getting the issue, but taking out the Reader and using Using blocks will clean up your code.

Also, since I can preach in this box, do not use string concatenation with your queries. If I were to type "a'; DROP TABLE [Login]; --" in your user name box, I would delete your login table. Learn how to use parameters with your queries to make your site safe from SQL Injection attacks.