Code performance and size

Question

0.00/5 (No votes)

See more: (untagged)

Other than saving some lines of code, does approach 2 have any merits in terms of performance and/or code space?

Approach 1

HRESULT FinalConstruct()
{
    HRESULT hr;
    hr = CoCreateInstance(CLSID_C1, ...);
    if(FAILED(hr))
    {
        return hr;
    }
    hr = CoCreateInstance(CLSID_C2, ...);
    if(FAILED(hr))
    {
        return hr;
    }		
    return S_OK;
}

Approach 2

HRESULT FinalConstruct()
{
    HRESULT hr;
    hr = CoCreateInstance(CLSID_C1, ...);
    if(SUCCEEDED(hr))
    {
        hr = CoCreateInstance(CLSID_C2, ...);
    }
    return hr;
}

Posted 26-Mar-10 11:20am

Sharjith

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Christian Graus · Accepted Answer · 2010-03-26T11:24:00

If you want to save lines, why do you declare hr seperate to giving it a value ?

The second one obviously does less checks and so is faster. But you'd never notice the difference, or even be able to measure it, so it's not worth worrying about. Write what seems the most legible to you, readable code is more maintainable and that matters more than saving the odd clock cycle.