problem in getting data from stored procedure

Question

0.00/5 (No votes)

See more:

May i know whats problem with my code, the procedure executed correct only, but here userId am getting zero (0)

C#

public static bool AdminLogin(string username, string password, out int userId)
    {
        bool IsUser = false;

        using (SqlConnection conn = new SqlConnection(Constants.CONNECTION))
        {
            using (SqlCommand cmd = new SqlCommand(Constants.Procs.CHECK_ADMIN_LOGINS, conn))
            {
                cmd.CommandType = CommandType.StoredProcedure;

                cmd.Parameters.Add("@Username", SqlDbType.VarChar, 20).Value = username;
                cmd.Parameters.Add("@Password", SqlDbType.VarChar, 20).Value = password;
                cmd.Parameters.Add("@UserId", SqlDbType.SmallInt).Value = ParameterDirection.Output;
                cmd.Parameters.Add("@IsUser", SqlDbType.Bit, 2).Value = ParameterDirection.Output;

                conn.Open();
                cmd.ExecuteNonQuery();

                int.TryParse(Convert.ToString(cmd.Parameters["@UserId"].Value), out userId);

                return Convert.ToBoolean(cmd.Parameters["@IsUser"].Value);
            }
        }
        return IsUser;
    }

Posted 25-Oct-13 21:36pm

NagarajDJ

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2013-10-25T21:50:00

Solution 1

Why do you think that setting the Value of a parameter to "ParameterDirection.Output" is going to magically cause it to become an output parameter? Do you think that setting it to your username magically makes it your user?

Try this:

C#

cmd.Parameters.Add("@UserId", SqlDbType.SmallInt).Direction = ParameterDirection.Output;

Posted 25-Oct-13 21:50pm

OriginalGriff

Comments

NagarajDJ 26-Oct-13 7:11am

i declared @UserId as output parameter in procedure so, thats why am send it as output parameter

OriginalGriff 26-Oct-13 7:21am

Yes, I guessed that. But you don't tell the SqlCommand it's an output parameter by setting teh Value - you do it by setting the Direction...