'minValue' cannot be greater than maxValue error.

Question

0.00/5 (No votes)

See more:

Hello,

I am trying to read in a text file (Words.txt) and then select a word out from the "Words.txt" file.

However I am now receiving a 'minValue' cannot be greater than maxValue error.

Can anyone help me with what I may have done wrong?

My WordListHelper class:

public class WordListHelper
    {

        private readonly List<string> _wordList = new List<string>();        

        private async void ProjectFile()
        {            
                var _Folder = Windows.ApplicationModel.Package.Current.InstalledLocation;
                _Folder = await _Folder.GetFolderAsync("Hangman");
 
                // acquire file
            
                StorageFolder sf = KnownFolders.DocumentsLibrary;
                StorageFile file = await sf.GetFileAsync("Words.txt");
                string _wordList = await FileIO.ReadTextAsync(file);            
        }

        public string Getword()
        {
            Random r = new Random();

            int i = r.Next(0, _wordList.Count - 1);

            return _wordList.ElementAt(i);
        }

    }
}

Line of code that is throwing the error:

int i = r.Next(0, _wordList.Count - 1);

Regards,

Glen.

Posted 9-Oct-13 2:24am

Glen Childs

Add a Solution

2 solutions

Solution 1

Looks like _wordList.Count equals zero.
Are you sure that _wordlist is filled with all the data needed when you call GetWord()?

Posted 9-Oct-13 2:31am

lukeer

Comments

Glen Childs 9-Oct-13 9:11am

I thought it was the FileIO.ReadText async that read the contents of the file to the _wordList list.

lukeer 10-Oct-13 4:33am

Sure it does. But from looking at your code, I'm not sure it is finished doing so at the time GetWord() is called.
If it is not, then _wordList may be empty, Count therefore equal zero, Count-1 equal -1 and that being less than the literal zero in r.Next(0, _wordList.Count - 1); is not supported by that method.

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

phil.o · Accepted Answer · 2013-10-09T02:33:00

It seems _wordList is empty, so _wordList.Count - 1 = -1

First of all since _wordList is declared at your class level you should not prefix its use with type in the ProjectFile() method:

C#

private async void ProjectFile()
{
        var _Folder = Windows.ApplicationModel.Package.Current.InstalledLocation;
        _Folder = await _Folder.GetFolderAsync("Hangman");

        // acquire file

        StorageFolder sf = KnownFolders.DocumentsLibrary;
        StorageFile file = await sf.GetFileAsync("Words.txt");
        string result = await FileIO.ReadTextAsync(file);
        _wordList.Add(result);
}

Then you should check for the content of _wordList before trying to use it in your GetWord() method:

C#

public string Getword()
{
    Random r = new Random();
    int i = -1;
    if (_wordList.Count > 0) {
       i = r.Next(0, _wordList.Count - 1);
    }
    return (i > -1) ? _wordList.ElementAt(i) : string.Empty;
}

Hope this helps.