Want To Capitalize 1st Letter Of String,but the function toupper not working.Dont know why ?

Question

1.00/5 (1 vote)

See more:

C++

void main()

clrscr();

int toupper();
char str[20]="i am good";
int length,i;

length=strlen(str);
str[0]=toupper(str[0]);  //Error here (Extra Parameter in call to toupper() ??

cout<<str[0];

for(i=1;i<length;i++)>
{
if(str[i]==' ')
str[i+1]=toupper(str [i+1]);   //Here aswell

cout<<str[i];
}
getch();
}

Posted 13-Sep-13 8:06am

kashiiii

Updated 13-Sep-13 8:34am

ridoy

v3

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Ron Beyer · Accepted Answer · 2013-09-13T08:41:00

Solution 1

You could just do this:

C++

if (str[0] >= 97 && str[0] < 173)
    str[0] -= 32;

Take a look at an ascii chart once, you'll see how the are all spaced.

Your problem is that you've defined toupper() as an integer something or other, so you aren't using the stdlib code, you are doing something weird. Remove the int toupper() line from just above the string and see if it works, you didn't outline what libraries you are using so not sure that you have the right includes.

Posted 13-Sep-13 8:41am

Ron Beyer

Updated 13-Sep-13 8:42am

v2

Comments

CPallini 13-Sep-13 17:34pm

My 5. The OP code actually declares toupper as a void function returning and int.

Ron Beyer 13-Sep-13 18:41pm

Thanks, not sure why the downvote (know it wasn't you), seems perfectly legal if you just want to capitalize the first letter of a string.

CPallini 14-Sep-13 2:41am

I don't understand the downvote too (I gave you 5, of course).

kashiiii 13-Sep-13 20:53pm

Yeah Working Now Thanks Ron beyer :),i am working with ctype.h & the problem was with int toupper; which i declared

Richard MacCutchan 14-Sep-13 5:32am

You should not use numbers, especially decimals, in statements such as the above, as it's difficult to know what they represent. Use the actual characters to represent themselves like:


if (str[0] >= 'a' && str[0] <= 'z')
    str[0] -= ' ';