Unable to navigate between windows forms

Question

5.00/5 (1 vote)

See more:

VS2012

Hi,
I am new to windows application. I have two forms and i want to navigate between these forms. When I Click button on form1, it moves to form2. The problem is when i click on button on form2 to navigate to form1, it closes the application. I am using the following code

Form1:

C#

private void button1_Click_1(object sender, EventArgs e)
       {
           var frm2 = new Form2();
           frm2.Show();
           this.Close();
       }

Form2:

C#

private void button2_Click(object sender, EventArgs e)
        {
            
            var frm1= new Form1();           
            frm1.Show();
            this.Close();
        }

I Shall be thankful for your help.
Regards
Usama

Posted 13-Jul-13 10:11am

osama.javed

Add a Solution

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

DaveyM69 · Answer 1 · 2013-07-14T10:14:00

Using the code you have been given so far you will be creating a new instance of Form1 each time the button in Form2 is clicked, which is probably not what you are wanting.

To show your original Form1 you should create an event in Form2 that your hidden Form1 instance subscribes to, so it can show itself:

C#

// In Form2
public event EventHandler ButtonClicked;

protected virtual void OnButtonClicked(EventArgs e)
{
    EventHandler eh = ButtonClicked;
    if (eh != null)
        eh(this, e);
}
private void button1_Click(object sender, EventArgs e)
{
    OnButtonClicked(e);
}

C#

// In Form1
private void button1_Click(object sender, EventArgs e)
{
    // A new Form2 instance. Cache this in a field and only create if null if you want the same Form2 instance each time
    Form2 form2 = new Form2();
    form2.ButtonClicked += new EventHandler(form2_ButtonClicked);
    form2.Show();
    Hide();
}
private void form2_ButtonClicked(object sender, EventArgs e)
{
    Form form2 = sender as Form;
    if (form2 != null)
    {
        form2.Close();
        Show();
    }
}

Another way is Constructor Injection into Form2 so it receives the Form1 instance, but this is rarely a good idea as it couples Form2 to Form1.

bunzitop · Answer 2 · 2013-07-14T05:16:00

Solution 2

Form1:

C#

private void button1_Click_1(object sender, EventArgs e)
        {
            var frm2 = new Form2();
            frm2.Show();
            this.Hide()
        }

:

Form2

private void button2_Click(object sender, EventArgs e)
        {
            
            var frm1= new Form1();           
            frm1.Show();
            this.Close();
        }

Hope this will help you! :)

Posted 14-Jul-13 5:16am

bunzitop

Comments

DaveyM69 14-Jul-13 16:17pm

You are creating a new Form1 every time the Button is clicked in Form2. The OP hasn't stated whether this is what he needs, but normally the initial instance is required.
Additionally, these instances are only ever hidden and never closed - that's going to start using a lot of unnecessary memory very quickly!

**Zoltán Zörgő** · Answer 3 · 2013-07-13T10:54:00

Solution 1

Of course, because you have a main form[^]. You could change visibility instead, and don't instantiate the form all the time!

Posted 13-Jul-13 10:54am

Zoltán Zörgő