Should I expose a collection as a method.

See more:

C#

collections

Hi all,

I've been writing a provider that uses generics to allow for xml serialization of simple classes for storage on low to medium use websites.

The system works great but when I used FXcop on my project I received the warning:"Properties should be used instead of Get/Set methods " on my method GetAllItems()

Now GetAllItems() returns a collection that acts as the only means to search for my generic type with my provider.

as follows.....

XmlProvider<Person> xmlProvider = new XmlProvider<Person>(path);
var q = from item in xmlProvider.GetAllItems() where item.Name.Equals("James South") select item;
Person p = q.FirstOrDefault();

Is that acceptable practice or is there a better method? Am I missing something simple?

Many thanks?