vb.net repeating messagebox help

Question

0.00/5 (No votes)

See more:

, +

sir! please help. this is my output:http://tinyurl.com/mvnfvlh[^]

an error provider shows up when user missed to enter a value to some fields so the system will not allow the user to save record to the database. user must fill all fields. assuming that the messagebox is my save code, after entering data to that field/s that needs to enter a value.Now, the problem is this messagebox always repeat according to how many fields that the user missed to enter a data. i dont know where to put this save and messagebox code. or some gives me a better solution for this

my code:

VB

Private Sub Button2_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles Button2.Click

        Try

            For Each item As Control In GroupBox1.Controls

                If item.Text = Nothing Then

                    ErrorProvider1.SetError(item, "enter a value")

                Else

                    ErrorProvider1.SetError(item, "")

                    ''code to save
                    ''

                    'Me.Validate()
                    'Me.UserprofileBindingSource.EndEdit()
                    'Me.TableAdapterManager.UpdateAll(Me.SampleDataSet)
                    MessageBox.Show("Saved", "System")
                End If

            Next

        Catch ex As Exception

        End Try

    End Sub

Posted 20-May-13 6:19am

akosisugar

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Pheonyx · Accepted Answer · 2013-05-20T06:41:00

Firstly, this is not the best approach to screen validation. You should take advantage of controls "Validating" and "Validated" methods. But based on what you have done, I would do something as follows:

VB

Private Sub Button2_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles Button2.Click

        Try

            Dim PassedValidation as Boolean = True
            For Each item As Control In GroupBox1.Controls

                If item.Text = Nothing Then

                    ErrorProvider1.SetError(item, "enter a value")
                    PassedValidation = False

                Else

                    ErrorProvider1.SetError(item, "")

                End If

            Next
            If PassedValidation Then
            
                     ''code to save
                    ''

                    'Me.Validate()
                    'Me.UserprofileBindingSource.EndEdit()
                    'Me.TableAdapterManager.UpdateAll(Me.SampleDataSet)
                    MessageBox.Show("Saved", "System")
            End If


        Catch ex As Exception

        End Try

    End Sub

This way all the validation runs, then if any one or more fail to validate then the save function will not execute.

Your code was currently going to try and save each time a control passed validation.