Named event vs INotifyPropertyChanged

Question

1.00/5 (1 vote)

See more:

I'm building a little library for timers, just for a bit of fun and as a training in some coding practices. I came across a question and I can't find a proper answer through google (yes, I looked thoroughly, unless I'm not aware of the correct terminology). In my timer I have a property IsStarted. I want to be notified when it's value changes (each time the Start() or Stop() action is called.

On one hand I have what I call named events. This is what I use now. Let me give you an example, it will illustrate what I mean more clearly than when I try to describe it.
(I call it named events because the events are named after what happens, in this case the event fires when the IsStarted property changed.)

C#

public class MyTimer
{
  private bool _isStarted;

  public delegate EventHandler OnIsStartedChanged;

  public bool IsStarted
  {
    get { return _isStarted; }
    private set
    {
      _isStarted = value;
      // call function to indicate that the property has changed
      OnIsStartedChanged();
    }
  }
}

On the other hand I have INotifyPropertyChanged. This will save me (when I work with a load of properties I want to monitor) a lot of work in the timer class, but will give me extra work when I have to implement the callback function.

The ChangedProperty event fires and now I have to see which property changed and what I want to do with each property.

Now I'm wondering what is the best way? What is the most standard compliant? What will give me the cleanest code? Or is it just a matter of personal taste?

Posted 13-May-13 3:20am

KenBonny

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Yuriy Loginov · Answer 1 · 2013-05-13T03:37:00

C#

public interface IOnStartChanged
        { 
            public void OnIsStartedChanged(); 
        }

        public class MyTimer
        {
            private List<IOnStartChanged> on_changed_listener = new List<IOnStartChanged>;();
            private bool _isStarted;

            public void addOnChangedListener(IOnStartChanged listener)
            {
                on_changed_listener.Add(listener);
            }

            public void removeOnChangedListener(IOnStartChanged listener)
            {
                on_changed_listener.Remove(listener);
            }

            public bool IsStarted
            {
                get { return _isStarted; }
                private set
                {
                    _isStarted = value;
                    foreach (IOnStartChanged listener in on_changed_listener)
                        listener.OnIsStartedChanged();
                }
            }
        }