check if username password exists in database

Question

0.00/5 (No votes)

See more:

I am using visual studio and access 2012.
I did a login form with passwordbox and username textbox.
I want to check if the username password exists in the database.
I did this.

C#

cmd.CommandText = "SELECT * FROM LOGIN WHERE username= '"+UserName+"' AND password='"+PassWord+"'";
            
           // cmd.CommandText = "INSERT INTO Login VALUES('CHEKH','CHEKH')";
            OleDbDataReader reader = cmd.ExecuteReader();
            if (reader.Read())
            {
                MessageBox.Show("ID exists");
            }

It worked but I don't know how. Is this the correct way?

Posted 28-Apr-13 7:12am

missak boyajian

Updated 28-Apr-13 8:01am

NotPolitcallyCorrect

v2

Add a Solution

Comments

[no name] 28-Apr-13 14:02pm

You should never create SQL statements with string concatenation. Other than that, if it worked then how could not be correct?

missak boyajian 28-Apr-13 17:13pm

What should I use instead?

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Dave Kreskowiak · Answer 1 · 2013-04-28T09:03:00

Solution 1

No, it's not correct, in many ways. Not the least of which is that you're storing passwords unencrypted in the database. If your database gets hacked, you just screwed all of your customers into changing their passwords everywhere else they have accounts.

Read these[^].

and these[^].

Posted 28-Apr-13 9:03am

Dave Kreskowiak

Updated 28-Apr-13 9:04am

v2

Comments

missak boyajian 28-Apr-13 17:12pm

Thanks for the answer. It seems a little bit complicated but I will see what I can do.