ASP.NET SqlDataReader not reading value !

Question

0.00/5 (No votes)

See more:

, +

Hi,

Can anyone tell me why datareader is no reading user_id from this code?

I debugged and the user_id_select remains 0 and I am getting no errors.

VB

Protected Sub btnAddUser_Click(sender As Object, e As EventArgs) Handles btnAddUser.Click

        Dim conn As New SqlConnection("Data Source=BRIAN-PC\SQLEXPRESS;Initial Catalog=master_db;Integrated Security=True")
        Dim searchComm As String = "SELECT user_id FROM users WHERE username=@username"
        Dim user_id_select As New Integer

        Dim searchSQL As New SqlCommand

        conn.Open()

        searchSQL = New SqlCommand(searchComm, conn)
        searchSQL.Parameters.AddWithValue("@username", txtUserSearch.Text.ToString)

        Dim datareader As SqlDataReader = searchSQL.ExecuteReader()

        datareader.Read()

        While datareader.Read

            user_id_select = datareader("user_id")

        End While


        datareader.Close()
        conn.Close()

        Dim addComm As String = "INSERT user_id, project_id INTO user_project VALUES (@UserID,@ProjectID)"

        Dim addSQL As New SqlCommand

        conn.Open()

        addSQL = New SqlCommand(addComm, conn)

        addSQL.Parameters.AddWithValue("@UserID", Convert.ToInt32(user_id_select))
        addSQL.Parameters.AddWithValue("@ProjectID", Convert.ToInt32(Session("project_id")))

        Dim datareader2 As SqlDataReader = searchSQL.ExecuteReader()




        datareader.Close()
        conn.Close()




    End Sub

Posted 23-Apr-13 3:55am

Member 9978591

Add a Solution

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Pallavi Waikar · Answer 1 · 2013-04-23T04:31:00

it is because u r already reading value from reader remove this line from code datareader.Read()
i.e

VB

Protected Sub btnAddUser_Click(sender As Object, e As EventArgs) Handles btnAddUser.Click

           Dim conn As New SqlConnection("Data Source=BRIAN-PC\SQLEXPRESS;Initial Catalog=master_db;Integrated Security=True")
           Dim searchComm As String = "SELECT user_id FROM users WHERE username=@username"
           Dim user_id_select As New Integer

           Dim searchSQL As New SqlCommand

           conn.Open()

           searchSQL = New SqlCommand(searchComm, conn)
           searchSQL.Parameters.AddWithValue("@username", txtUserSearch.Text.ToString)

           Dim datareader As SqlDataReader = searchSQL.ExecuteReader()

           //datareader.Read()

           While datareader.Read

               user_id_select = datareader("user_id")

           End While


           datareader.Close()
           conn.Close()

           Dim addComm As String = "INSERT user_id, project_id INTO user_project VALUES (@UserID,@ProjectID)"

           Dim addSQL As New SqlCommand

           conn.Open()

           addSQL = New SqlCommand(addComm, conn)

           addSQL.Parameters.AddWithValue("@UserID", Convert.ToInt32(user_id_select))
           addSQL.Parameters.AddWithValue("@ProjectID", Convert.ToInt32(Session("project_id")))

           Dim datareader2 As SqlDataReader = searchSQL.ExecuteReader()




           datareader.Close()
           conn.Close()




       End Sub

ZurdoDev · Answer 2 · 2013-04-23T04:31:00

Solution 2

You called .Read() twice on the DataReader. So it has advanced too far.

Since you are only expecting one user record try something like this instead

VB

If datareader.HasRows THEN
  datareader.Read()
  user_id_select = datareader("user_id")
End If

Posted 23-Apr-13 4:31am

ZurdoDev

OriginalGriff · Answer 3 · 2013-04-23T04:35:00

Solution 3

Brackets, my friend, brackets.
Change:

VB

searchSQL.Parameters.AddWithValue("@username", txtUserSearch.Text.ToString)

To:

VB

searchSQL.Parameters.AddWithValue("@username", txtUserSearch.Text.ToString())

But in fact you don't need the ToString at all, since a Text property is a string already, so use this instead:

VB

searchSQL.Parameters.AddWithValue("@username", txtUserSearch.Text)

Posted 23-Apr-13 4:35am

OriginalGriff

Comments

ZurdoDev 23-Apr-13 15:04pm

VB doesn't care about () for functions that take no parameters. At least that is how I remember it when I did it years ago. :)