Is this correct code?

Question

0.00/5 (No votes)

See more:

Hello,

I am working on a code where the architecture is as follows:

- entities and DTO are generated from tables and views from the database. The data provider layer, validation and CRUD operations are also generated.
- Remains to make the business. The business consists of a series of simple methods. I distinguish two types: the "get" and "save".

C#

public Ilist<MyDto> GetMyDtoBySomethingId(Guid somethingId) {...}
public void SaveMyDto(MyDto my) {...}

I would like to know if it is correct to work with this kind of concept like passing Guid to get something. In each of y business class I have something like unlimited possibilities of get by this or by that with always a Guid as parameter. The get operations return me tables or views. Is that different from old typed dataset? The business seems to be build by the needs of the GUI layer. There is no rules. Fortunately I only have one save operation by DTO and only on DTO generated from real tables and not views.

Posted 10-Apr-13 23:40pm

Bastien Vandamme

Updated 10-Apr-13 23:45pm

v2

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Maksud Saifullah Pulak · Answer 1 · 2013-04-11T00:55:00

Solution 1

public List<MyDto> GetMyDtoBySomethingId(Guid somethingId) 
{
//You logic goes here like.....

 MyDto _MyDtoList = new MyDto(); 
}

public void SaveMyDto() 
{
//You logic goes here like.....

     MyDto _My = new MyDto();
}

Posted 11-Apr-13 0:55am

Maksud Saifullah Pulak