Optimization Options for a C# function

Question

2.00/5 (1 vote)

See more:

So I have this function and it works and does exactly what I need it to do, however; the function is extremely slow...not minutes slow but, I imagine it could get there as the files I receive get larger. I just need a few suggestions to steam line or optimize the function to process just a little faster. This is a small part a C# / Silverlight application.

The size of the files currently range from:
1kb (no wait...me likey)

to around

350kb (renders application non-responsive...me no likey)

C#

private void MyStupidButton_ClickFunction(object sender, RoutedEventArgs e)
        {
            fileContents.Text = "";
            if (Application.Current.HasElevatedPermissions)
            {
                //UPDATE FILE SELECTION PROCESS
                _openFileDialog = new OpenFileDialog();
                _openFileDialog.Filter = "Text Files (.txt)|*.txt";
                _openFileDialog.Multiselect = false;
                List<string> list = new List<string>();

                bool? dialogResult = _openFileDialog.ShowDialog();
                if (dialogResult.Value)
                {
                    Stream fileStream = _openFileDialog.File.OpenRead();
                    using (StreamReader reader = new StreamReader(fileStream))
                    {
                        string line;
                        
                        while((line = reader.ReadLine()) != null)
                        {
                            list.Add(line);
                            fileContents.Text += line.ToString() + "\n";
                        }

                        FilePath.Text = _openFileDialog.File.FullName;
                        enableVerifyButton();
                    }
                    fileStream.Close();
                    var distinctLines = File.ReadLines(FilePath.Text).Distinct().Count();
                    var hasDuplicates = File.ReadLines(FilePath.Text).Count();

                    if (hasDuplicates > distinctLines)
                    {
                        duplicate.Text = "Duplicate Entries Found";
                    }
                    else
                    {
                        duplicate.Text = "No Duplicates Found";
                    }
                    enableClearButton();
                }
            }
        }

Any help is greatly appreciated and if I just need to learn patience, that's fine too.

Posted 2-Apr-13 8:29am

JustDaveL

Add a Solution

Comments

Sergey Alexandrovich Kryukov 2-Apr-13 14:35pm

Help with what? This is not a question.
OK, you know what the function should do, not please tell us about it.
Rename "MyStupidButton" to "MyCleverFunction" :-)
—SA

Kenneth Haugland 2-Apr-13 14:53pm

How about btnMeNoLikey? :laugh:

Sergey Alexandrovich Kryukov 2-Apr-13 16:44pm

That's the sure way to fail the project.
I used to allow myself to mentor people with the following: "Most important thing is a project is its name; should you choose a bad name, everything goes wrong" :-)
—SA

Kenneth Haugland 2-Apr-13 14:37pm

If you are just going to read a text fil why not use ReadAllLines instead? It retunrs a list of string.

[no name] 2-Apr-13 15:09pm

File IO is naturally slow. The only way you are going to optimize anything is to profile your code and see where the actual slowdown is.

Irina Pykhova 2-Apr-13 15:16pm

you can throw away a half of this method. For example, you don't use list at all. At least, you could use it to get line count directly without one more call to File.ReadLines. Read file once with ReadAllLines and use returned result to do other actions, don't read file many times.

Sergey Alexandrovich Kryukov 2-Apr-13 16:46pm

Oh, yes. The only issue is the total required memory, but, if a list can hold it all in memory, the string returned by ReadAllLines certainly can...
—SA

JustDaveL 3-Apr-13 8:30am

First of all...it is sad to think that everyone here would expect me to place proprietary information in a public forum. Shame on you. Of course these are not the names I use in the actual program and function.
Second...I tried using ReadAllLines and I have not found the proper assembly reference to be able to incorporate it. Silverlight seems to be funny like that, not allowing me to use everything that should be available to me, unfortunately I'm too far in to switch platforms and I have to deal with what I have.
Third...I will be using the list later, I was just attempting to decrease the processing time of the current function before I add more code to it.

Like I said before "Any [help] (<= Here is the key word), is greatly appreciated and if I just need to learn patience, that's fine too." So I'm looking for help/assistance/suggestions/advice.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Matt T Heffron · Answer 1 · 2013-04-02T13:12:00

Like others said.
Here it's "consolidated":

C#

bool? dialogResult = _openFileDialog.ShowDialog();
if (dialogResult.HasValue && dialogResult.Value)
{
  FilePath.Text = _openFileDialog.File.FullName;
  string[] allLines = File.ReadAllLines(FilePath.Text);  // read the file only ONCE

  fileContents.Text = string.Join("\n", allLines);
  enableVerifyButton();
 
  if (allLines.Length > allLines.Distinct.Count)
  {
    duplicate.Text = "Duplicate Entries Found";
  }
  else
  {
    duplicate.Text = "No Duplicates Found";
  }
  enableClearButton();
}

This may not be optimal but it ought to be faster.

Do you really need the contents in the fileContents.Text control?
This requires building the big string.