Multiple Replace Text Data in Textbox

Question

0.00/5 (No votes)

See more:

VS2008

I'm using small application. It has two textboxes. I'm putting input data in textbox1 and output data in textbox2. I want to replace multiple strings, where each string to replace has a unique string to be replaced with, as in the following:

"KB" to "kilobyte"
"MB" to "megabyte"
"GB" to "gigabyte"
"TB" to "terabyte"

For this I am using this code:

VB

Private Sub Button1_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles Button1.Click
        TextBox2.Text = TextBox1.Text

        Dim i As Integer = 0
        Do While i < 1000
            i = i + 1
            If InStr(TextBox2.Text, "kb") Then
                TextBox2.Text = Replace(TextBox2.Text, "kb", "kilobyte")
            ElseIf InStr(TextBox2.Text, "mb") Then
                TextBox2.Text = Replace(TextBox2.Text, "mb", "megabyte")
            ElseIf InStr(TextBox2.Text, "gb") Then
                TextBox2.Text = Replace(TextBox2.Text, "gb", "gigabyte")
            ElseIf InStr(TextBox2.Text, "tb") Then
                TextBox2.Text = Replace(TextBox2.Text, "tb", "terabyte")
 
           End If
        Loop

    End Sub

Is there any easier way than my above code to accomplish this task?

Posted 26-Jan-10 19:10pm

Jekson9007

Updated 26-Jan-10 20:05pm

AspDotNetDev

v3

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Christian Graus · Accepted Answer · 2010-01-26T19:32:00

Yes. It's all a waste of time. Plus, your code just will work for one of these values, if more than one is there. Just put the Replace calls in a block. Get rid of the loop.

VB

TextBox2.Text = Replace(TextBox2.Text, "kb", "kilobyte")
TextBox2.Text = Replace(TextBox2.Text, "mb", "megabyte")
TextBox2.Text = Replace(TextBox2.Text, "gb", "gigabyte")
TextBox2.Text = Replace(TextBox2.Text, "tb", "terabyte")

That's all you need. Also, any VB method that has no dot in it ( so InStr, instead of TextBox2.Text.Contains ), NEVER use. That's stuff left in because VB6 users were presumed to be too stupid to learn .NET.

AspDotNetDev · Accepted Answer · 2010-01-26T19:39:00

You could use a regular expression with a match evaluator in combination with a dictionary (the dictionary will improve performance over the technique you are currently using):

VB.NET

Public Class Form1
    Private items As New Dictionary(Of String, String)
    Public Sub DoIt()
        items("x") = "the x"
        items("y") = "the y"
        items("z") = "the z"
        Dim pattern As String = "x|y|z"
        Dim reggy As New System.Text.RegularExpressions.Regex(pattern, _
            System.Text.RegularExpressions.RegexOptions.IgnoreCase)
        Dim input As String = "The x saw the y and z."
        Dim output As String = reggy.Replace(input, _
            New System.Text.RegularExpressions.MatchEvaluator(AddressOf ReplaceUnit))
    End Sub
    Private Function ReplaceUnit(ByVal match As _
        System.Text.RegularExpressions.Match) As String
        Return items(match.Value.ToLower())
    End Function
End Class

Multiple Replace Text Data in Textbox

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0