Javascrip DOM problem

Question

0.00/5 (No votes)

See more:

I am trying to get used to javascript DOM.
But I can't figure out the issue.

The function should showing the name I enter with hello, but nomatter what I done, it only show hello, who.

html code:

<pre>
<form>
    <input type="text" placeholder="name" autocomplete="off" onkeyup="full()" id="fname">
</form>
 <p id="p"></p>

here is my js code.

JavaScript

var name = document.getElementById("fname");
var p = document.getElementById("p");
              function full(){
                if (name.value) {
                    p.innerHTML = "hello, ${name.value}";
                    console.log(1);
                }
                else {
                    p.innerHTML = "hello, who";
                    console.log(2);
                }
              }

What I have tried:

I changed event from oninput to onkeyup, but got same resulte.

Posted 13-Dec-23 5:55am

nonprocoder

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard Deeming · Accepted Answer · 2023-12-13T06:03:00

Solution 1

The first problem is that you're using a regular string rather than a Template literal[^].

The second problem is that name is a property on the window object. When the event handler function is called, that property hides the name variable. Change your variable to something like fname instead.

JavaScript

const fname = document.getElementById("fname");
const p = document.getElementById("p");

function full() {
    if (fname.value) {
        p.innerHTML = `hello, ${fname.value}`;
    } else {
        p.innerHTML = "hello, who";
    }
}

Demo[^]

Posted 13-Dec-23 6:03am

Richard Deeming

Comments

nonprocoder 13-Dec-23 12:18pm

hi, Thank you for your answer, I have fixed the main issue here.
But I have another question would like to ask, it just happened to me.
`hello, ${fname.value}` I don;t know why in my vs code, ${fname.value} is not a value, it's a string, just like hello. I copied your code, it works, but I did on my keyboard, it doesn't work. do you have any idea maybe I made another mistaken?

nonprocoder 13-Dec-23 12:29pm

But If I change to 'hello, ' + fullname.value, it worked.

nonprocoder 13-Dec-23 12:33pm

fixed it, i was using Single and double quotes instead of back ticks