Update code of C# is not working

Question

1.00/5 (2 votes)

See more:

try
            {
                string updatequery = string.Format("Update Facultyleave set Faculty_ID = '{0}', LeaveType = '{1}', TotalBalance = '{2}', Month ='{3}', Days= '{4}', LeaveDate= '{5}', LeaveTime= '{6}', EndDate = '{7}', EndTime = '{8}', SanctionedLeave = '{9}', AvailedLeave = '{10}', Balance = '{11}', Reason = '{12}'" +
                    " where LeaveID = '{13}' ", txtID.Text.Trim(), cboLeaveType.Text.Trim(), txttotalleave.Text.Trim(), cboMonth.Text, NoOfDays.Text,
                    dtpLeavedate.Value.ToString("yyyy-MM-dd"), dtpLeaveTime.Value.ToString("HH:mm:ss"), dtpEndDate.Value.ToString("yyyy-MM-dd"),
                    dtpEndTime.Value.ToString("HH:mm:ss"), txtLSanctioned.Text, txtLAvailed.Text.Trim(),
                    txtBalance.Text, txtReasons.Text, Convert.ToString(dgvFacultyLeaveList.CurrentRow.Cells[0].Value).Trim());

                bool result = DatabaseAccess.UpdateData(updatequery);

                if (result)
                {
                    MessageBox.Show("Updated Successfully.");
                    EnableComponents();
                    FillGrid("");
                }
                else
                {
                    MessageBox.Show("Unexpected error occurred. Please contact the administrator.");
                }
            }
            catch (Exception ex)
            {
                MessageBox.Show(ex.Message, "Error", MessageBoxButtons.OK, MessageBoxIcon.Error);
            }

What I have tried:

i try alot of other codes but its not updating the database all the values are corret

Posted 9-Dec-23 1:50am

farzana Mengal

Add a Solution

Comments

Richard MacCutchan 9-Dec-23 8:41am

Have you previously validated all the input parameters that you are trying to store? By the look of that code you have not, so you could be using any random information. And why are you using two text strings to store a date and time instead of a proper DateTime type?

[no name] 9-Dec-23 12:28pm

Incremental development: no parms, 1 parm, 2 parms, n parms.

Dave Kreskowiak 9-Dec-23 14:54pm

The major problem with this code is you're using string concatentation to build the SQL query. ALWAYS USER PARAMETERIZED QUERIES! NEVER USER STRING CONCATENTATION!

Also, why are you storing Dates and Times as strings? You're only begging for problems when you go to search on those fields and when you sort on them.

Richard Deeming 11-Dec-23 4:21am

Everything you wanted to know about SQL injection (but were afraid to ask) | Troy Hunt[^]
How can I explain SQL injection without technical jargon? | Information Security Stack Exchange[^]
Query Parameterization Cheat Sheet | OWASP[^]

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

M Imran Ansari · Answer 1 · 2023-12-11T07:33:00

It's recommended to use parameterized queries to avoid SQL injection attacks and improve code readability for better debugging. There are some links are provided in above comments for your reference, here is an example to start.

C#

string updatequery = "UPDATE Facultyleave SET Faculty_ID = @FacultyID, LeaveType = @LeaveType, TotalBalance = @TotalBalance, Month = @Month, Days = @Days, LeaveDate = @LeaveDate, LeaveTime = @LeaveTime, EndDate = @EndDate, EndTime = @EndTime, SanctionedLeave = @SanctionedLeave, AvailedLeave = @AvailedLeave, Balance = @Balance, Reason = @Reason WHERE LeaveID = @LeaveID";
using (SqlCommand cmd = new SqlCommand(updatequery, "SqlConnection"))
{
    cmd.Parameters.AddWithValue("@FacultyID", txtID.Text.Trim());
    cmd.Parameters.AddWithValue("@LeaveType", cboLeaveType.Text.Trim());
    // Add other parameters similarly with correct datatype and value...

    cmd.Parameters.AddWithValue("@LeaveID", Convert.ToString(dgvFacultyLeaveList.CurrentRow.Cells[0].Value).Trim());

    bool result = DatabaseAccess.UpdateData(cmd);

    // Rest of your code..
}