Could not see array of strings using directory.getfiles

Question

1.00/5 (2 votes)

See more:

i have several files in folder ,i want to see all extract there name by code
i use
n=Directory.GetFiles(CurrentDirectory).Length(CurrentDir);
then i used a for loop to see their names ,i have seen some names but not all

What I have tried:

fyles = Directory.GetFiles(CurrentDirectory);
n=Directory.GetFiles(CurrentDirectory).Length(CurrentDir);
for(i=0;i<n;i++)
MessageBox.Show(fyles[i]);

Posted 6-Dec-23 0:53am

Engineer khalid

Updated 6-Dec-23 0:54am

Add a Solution

2 solutions

Solution 2

Quote:
i have seen some names but not all

Please, refer to the MSDN documentation: Directory.GetFiles Method (System.IO) | Microsoft Learn[^]

As you can see, there is a few overloaded methods. Maybe you need to use that one which uses EnumerationOptions Class (System.IO) | Microsoft Learn[^].

Quote:
The attributes to skip. The default is FileAttributes.Hidden | FileAttributes.System.

I do believe you want to skip none :)

On the other hand, i'd suggest to read this: Directory.Get.Files search pattern problem[^]

Tip: You can use FileInfo class[^] to get more information about particular file, such as (properties):
Attributes
CreationTime
CreationTimeUtc
Directory
DirectoryName
Exists
Extension
FullName
IsReadOnly
LastAccessTime
LastAccessTimeUtc
LastWriteTime
LastWriteTimeUtc
Length
LinkTarget
Name
UnixFileMode

Posted 6-Dec-23 1:12am

Maciej Los

Updated 6-Dec-23 1:20am

v3

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard Deeming · Accepted Answer · 2023-12-06T01:00:00

Solution 1

First problem: don't call GetFiles twice. If you want the number of files that were returned, look at the Length property on the array you've already stored.

Second problem: the Length property doesn't have any arguments. Which means your call to .Length(CurrentDir) must be calling an extension method that you've created. Since you haven't shown us that extension method, we can't tell you why it's not returning the correct value.

Third problem: nobody here has access to your disk. We cannot guess why you are not seeing all of the files you expect to see.

Try using:

C#

string[] files = Directory.GetFiles(CurrentDirectory);
for (int i = 0; i < files.Length; i++)
{
    MessageBox.Show(files[i]);
}

or:

C#

string[] files = Directory.GetFiles(CurrentDirectory);
foreach (string file in files)
{
    MessageBox.Show(file);
}

or even:

C#

foreach (string file in Directory.EnumerateFiles(CurrentDirectory))
{
    MessageBox.Show(file);
}

Posted 6-Dec-23 1:00am

Richard Deeming

Comments

Maciej Los 6-Dec-23 7:05am

Short and to the point!

Engineer khalid 6-Dec-23 8:17am

i need to store the file names to an array and send them to a text file like this

sw.WriteLine(file[i]); // <=== it did not works

Richard Deeming 6-Dec-23 8:20am

And what, precisely, does "it did not work" mean?

Remember, we cannot see your screen, access your computer, or read your mind. All we have to go on is what you tell us. Comments like "did not work" tell us precisely nothing!

Dave Kreskowiak 6-Dec-23 10:01am

NM. Not enough caffeine today. You have to show the error message you're getting, if any, or otherwise describe what's going on.

Where are you trying to write this file and what is the code that is setting that up?

Engineer khalid 7-Dec-23 1:16am

using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.Data;
using System.Drawing;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using System.Windows.Forms;

using System.IO;

namespace testGetFile
{
public partial class Form1 : Form
{
FileStream fs, fg;
StreamWriter sw;

protected override void OnClosing(CancelEventArgs e)
{
if (sw != null) sw.Close(); if (fg != null) fg.Close();
}
//--------------------------------------------------------
public Form1()
{
InitializeComponent();
}
//------------------------------------------------------
private void btnStartClick(object sender, EventArgs e)
{
int i, Nfile = 0;
string CurrentDirectory = "";
string[] iFile = new string[50];
for (i = 0; i < 50; i++) iFile[i] = "";
CurrentDirectory = Directory.GetCurrentDirectory();
//**********************************************************
fg = new FileStream("ListOfFileName.txt", FileMode.Truncate, FileAccess.Write);
StreamWriter sw = new StreamWriter(fg);
//----------------------------------------------------------
string[] files = Directory.GetFiles(CurrentDirectory);

i = 0;
Nfile = 0;
foreach (string file in files)
{
MessageBox.Show(file);
Nfile++;
}
for (i = 0; i < Nfile; i++)
{
iFile[i] = files[i];
sw.WriteLine(iFile[i]);
}
}//btnStartClick

}
}

Engineer khalid 7-Dec-23 1:21am

i should get all file names in the text file ListOfFileName.txt
but i found it is empty

Richard Deeming 7-Dec-23 3:35am

Probably because you never flush or close the StreamWriter created in your btnStartClick method, which hides the sw field declared in your form.

Your code is horrendously over-complicated:

public partial class Form1 : Form
{
    public Form1()
    {
        InitializeComponent();
    }

    private void btnStartClick(object sender, EventArgs e)
    {
        string CurrentDirectory = Directory.GetCurrentDirectory();
        string[] files = Directory.GetFiles(CurrentDirectory);
        
        // Assuming you want to limit your output to 50 files:
        if (files.Length > 50) Array.Resize(ref files, 50);
        
        string listFile = Path.GetFullPath("ListOfFileName.txt");
        File.WriteAllLines(listFile, files);
        
        MessageBox.Show($"List of files written to '{listFile}'");
    }
}

Engineer khalid 7-Dec-23 6:13am

may be the end character of files[i] is not \n
look at this
string[] mystr=new string[50];
i still could not save files[0],files[1],files[2]....so on
to
for(i=0;i<3;i++)//assume we have only 3 files
mystr[i]=files[i];

Richard Deeming 7-Dec-23 7:57am

And you still can't manage to ask a coherent question!

If you want anyone to be able to help you, you need to work on asking better questions. If you don't provide a clear description of the problem, nobody can help you.