Need to fetch notes from next record in SQL table

Question

1.00/5 (2 votes)

See more:

, +

Below is the table t1 in SQL with column like this, srno is the sequence just use to move cursor.

acctnum(c1)    note (c2)   srno
12             abc          1
               efd          2
               xyz          3
15             pqr          4
16             uio          5
               njk          6
               uuuwr        7
               kmjkj        8
18             zzzzzzz      9

I need the result like as below mention, it should be in single record

acctnum(c1)    note (c2)
12                  abc efd xyz
15                  pqr
16                  uio njk uuwr kmjkj
18                  zzzzzzzzz

What I have tried:

I have tried below cursor query to fetch it but it is not wokring properly as it is not fetching few records of note for few acctnum. Please help me to correct the code and get proper single record as per accountnumber.

SQL

SET NOCOUNT ON;
 
declare @accounttNumber varchar(100);
declare @note varchar(max);
declare @SrNo int;
declare @FinalNote varchar(max);
 
declare c1 cursor for 
SELECT [ACCTNUM],[note],[srno] FROM lk_tmp_data
 
open c1;
 
fetch next from c1 into @accounttNumber,@note,@SrNo;
 
WHILE @@FETCH_STATUS = 0
begin
	
	if (@SrNo!='')
	begin
	if (@accounttNumber!='')
	Begin
		print 'TicketNumber: '+@accounttNumber+' FinalNote : ' + @FinalNote;
		set @FinalNote = '';
	End
	--else 
		set	@FinalNote= @FinalNote + ' ' + @note+' ';
	end;
	--SET @SQLQuery ='';
	--EXEC (@SQLQuery)
	fetch next from c1 into @accounttNumber,@note,@SrNo;
end;
 
CLOSE c1;
DEALLOCATE c1;

Posted 10-Nov-23 0:52am

Member 11776570

Updated 10-Nov-23 1:14am

Maciej Los

v2

Add a Solution

Comments

CHill60 10-Nov-23 8:06am

Rarely, if ever, do you need to use any kind of loop in SQL - it is set-based. See my article Processing Loops in SQL Server[^]

CHill60 10-Nov-23 8:08am

Does the table really look like that?

acctnum(c1)    note (c2)   srno
12             abc          1
               efd          2
               xyz          3
15             pqr          4...etc

or does it look like

acctnum(c1)    note (c2)   srno
12             abc          1
12             efd          2
12             xyz          3
15             pqr          4...etc

Because if it doesn't look like the 2nd example it will be incredibly difficult to get your data back again

Member 11776570 10-Nov-23 9:02am

like this

Dave Kreskowiak 10-Nov-23 9:28am

I guarantee you your table doesn't look like that unless, UNLESS, you're storing data in string formats, making it neigh impossible to do any actual processing on it.

2 solutions

Solution 2

There's few ways to achieve that.
I'd like to provide a sample with Common Table Expressions:

SQL

;WITH CTE AS
(
  SELECT 1 Lvl, acctnum, note, srno, note newnote
  FROM Table1
  WHERE acctnum IS NOT NULL
  UNION ALL
  SELECT C.Lvl +1, C.acctnum, T.note, T.srno, CONCAT(C.newnote, ' ', T.note) newnote
  FROM CTE C
  INNER JOIN Table1 T
    ON (T.srno - C.srno = 1)
      AND T.acctnum IS NULL
),
FINAL AS
(
  SELECT *, ROW_NUMBER() OVER(PARTITION BY acctnum ORDER BY Lvl DESC) RN
  FROM CTE
)
SELECT acctnum, newnote note
FROM FINAL
WHERE RN =1

SQL Server 2022 | db<>fiddle[^]

Result:

acctnum 	note
12 	 	 	abc efd xyz
15 	 	 	pqr
16 	 	 	uio njk uuuwr kmjkj
18 	 	 	zzzzzzz

Posted 10-Nov-23 3:06am

Maciej Los

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard Deeming · Accepted Answer · 2023-11-10T02:59:00

You haven't specified which version of SQL Server you're using. Assuming 2017 or later, the simplest solution is to use STRING_AGG[^]:

SQL

SELECT
    acctnum,
    STRING_AGG(note, ' ') WITHIN GROUP (ORDER BY srno) As note
FROM
    YourTable
GROUP BY
    acctnum
;

If you're using an older version that doesn't support STRING_AGG, you'll need to use one of the alternative methods described here:
Concatenating Row Values in Transact-SQL - Simple Talk[^]