What's wrong in this problem?

Question

1.00/5 (2 votes)

See more:

an integer array Arr of size N and a number X.print all the indexes of the given X in the array, else print -1.

give output in 1-based indexing.

Input

5 6
2 6 3 6 6
Output:

2 4 5

What I have tried:

solution

int flag =0;
		int index =-1;
    for(int i=0; i<N; i++){
			if(arr[i]==X){
				flag =1;
				index = i+1;
			
			if(flag==1){
			 System.out.print(index + " ");
				
			}
			else{
				System.out.print("-1");
			   
			}
				}

Posted 20-Dec-22 1:53am

ak343

Updated 20-Dec-22 7:22am

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2022-12-20T02:19:00

You never clear the status of your flag: once set, it stays set for teh duration of your application ... Since your printing is all inside your loop, that could be important, wouldn't you say?

If you had used the debugger, a couple of minutes would have shown you what was wrong with your code: that would have been a lot quicker than asking here!
How you use it depends on your compiler system, but a quick Google for the name of your IDE and "debugger" should give you the info you need. Put a breakpoint on the first line in the function, and run your code through the debugger. Then look at your code, and at your data and work out what should happen manually. Then single step each line checking that what you expected to happen is exactly what did. When it isn't, that's when you have a problem, and you can back-track (or run it again and look more closely) to find out why.

Richard MacCutchan · Answer 2 · 2022-12-20T02:41:00

Solution 2

This is your third question today, I think it is time you went to Java Tutorials Learning Paths[^] and did some studying.

Posted 20-Dec-22 2:41am

Richard MacCutchan