How can I compact my code?

Question

0.00/5 (No votes)

See more:

Here are the variables if needed:

Python

Darkvision = ("None", False)
Stonecunning = ("None", False)
Stability = ("None", False)
Poison_Resistance = ("None", False)
Spell_Resistance = ("None", False)
Goblinfoe = ("None", False)
Giantfoe = ("None", False)

And the If in statements themselves

Python

if Darkvision in special_abilites:
    Darkvision = ("You can see 60ft in the darkness", True)
else:
    pass
if Stonecunning in special_abilites:
    Stonecunning = ("You can notice unusual stonework", True)
else:
    pass
if Stability in special_abilites:
    Stability = ("You are much harder to topple", True)
else:
    pass

Any ideas would be appreciated, Thanks!

What I have tried:

This is as compact as I can get it. I am just seeing if any could do it better than I.

Posted 20-Oct-22 5:41am

Brennon Nevels

Add a Solution

Comments

Richard MacCutchan 20-Oct-22 11:45am

Remove all the else: and pass lines, as they serve no purpose.

Brennon Nevels 20-Oct-22 12:05pm

Ok thanks

Member 15627495 21-Oct-22 0:12am

in the 'variable needed' section of code, as all the vars have the same state when init, you can let them with 'blank values' because It's a default value, which change when the special_abilities is set.
this section is kind of useless like that.
the hardest in coding sometimes is to don't write code... you write a kind of overload for nothing.

to see useless code, looks every time at what is written , for wich goal, and at which instant in your work flow.

and instead of the "if .... in special abilities" , you can write a function :set_abilities(string abilities_text ,boolean status) to set them. you'll just have to deal with 2 vars to set when calling a function, instead of this nested if /if /if then pattern. this section of code could be a case/break written you 'll get it more readable too.

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)