Index was outside the bounds of the array

Question

1.00/5 (1 vote)

See more:

Trouble!!! Help
index was outside the bounds of the array cs:33

What I have tried:

C#

using System.Collections;
using System.Collections.Generic;
using UnityEngine;
using UnityEngine.UI;

public class ComodScript : MonoBehaviour
{
   public GameObject[] Comods;
   int index;

   void Start()
   {
    index = 0;
   }

   void Update()
   {
    if(index > 3)
    index = 0;
    
    if(index==0)
    {
        Comods[0].gameObject.SetActive(true);
    } 
   }
   public void ButtonNext()
   {
    index += 1;

    for(int i = 0; i < 4; i++)
    {
        Comods[i].gameObject.SetActive(false);
        Comods[index].gameObject.SetActive(true);
    }
   }
   
}

Posted 31-Aug-22 10:07am

m0r yana

Updated 31-Aug-22 10:39am

PIEBALDconsult

v2

Add a Solution

Comments

PIEBALDconsult 31-Aug-22 16:23pm

I expect the value of index becomes 4. Would you like it to wrap back to 0 ?

m0r yana 31-Aug-22 16:35pm

yes, i am trying to change ui images with button in a circle

PIEBALDconsult 31-Aug-22 16:51pm

So you need to reset back to 0 when you hit 4.
index = ( index + 1 ) % 4

m0r yana 31-Aug-22 17:00pm

Thank you so much! it works! <3

PIEBALDconsult 31-Aug-22 17:03pm

Great. Also, rather than hard-coding 4, use Comods.Length

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2022-08-31T10:25:00

The error message means exactly what its says: you have tried to access an element of a collection that doesn't exist because the index is invalid.
In C#, indexes run from 0 to (N - 1), when N in the number of elements in the collection.
So for an array of three elements, the valid indexes would be 0, 1, and 2 only - any other value (positive or negative) will give you this error.

But we can't tell you why your index is invalid: we have no access to your data or the values in the index(es) you are using.

So it's going to be up to you.
Fortunately, you has the debugger to help you find out what is going on. Run your code in the debugger, and when the error occurs, it will stop so you can look at your variables and see what they contain.
Then you can start looking for why they are out of bounds.

Sorry, but we can't do any of that for you!

CPallini · Answer 2 · 2022-08-31T10:39:00

Solution 2

Quote:
public void ButtonNext()
{
index += 1; //<- here index might become 4

for(int i = 0; i < 4; i++)
{
Comods[i].gameObject.SetActive(false);
Comods[index].gameObject.SetActive(true);//<- here index = 4 is a problem
}
}

Posted 31-Aug-22 10:39am

CPallini

Comments

m0r yana 31-Aug-22 16:49pm

i have 4 elements in array

CPallini 1-Sep-22 1:18am

Indeed, you have items: 0,1,2,3.
You have NOT item 4.