By using while loop I get infinite lopp answer but where as by using same loop in functions I get correct answer HOW?

Question

1.00/5 (1 vote)

See more:

public static void main(String[] args) 
    {
     int arr[]={1,5,8,14,15,18};
     int start=0,end=arr.length-1,target=14;
     while(start<=end)
     {
         int mid=(start+end)/2;
         if(target<arr[mid])
             end=mid-1;
         else if(target>arr[mid])
             start=mid+1; 
         else if(target==arr[mid])
             System.out.print(mid);      
     }
     
    }

here i get answer as 33333333333........so on where as same loop using function i get exact answer exaplain please//

public static void main(String[] args) 
    {
     int arr[]={1,5,8,14,15,18};
     int target=14;
     int ans=binarysearch(arr,target);
     System.out.print(ans);
    }
   static int binarysearch(int arr[],int target)
   {
       int start=0,end=arr.length;
       while(start<=end)
       {
           int mid=(start+end)/2;
           if(target<arr[mid])end=mid-1;
           if (target>arr[mid])start=mid+1;
           else 
               return mid;
       }
       return -1;
   }

CAN ANY BODY EXPLAIN PLEASE......

What I have tried:

I Tried this code in java please explain how this possible.

Posted 30-Jul-22 19:06pm

Irfan bhaaai

Updated 31-Jul-22 8:32am

Add a Solution

Comments

[no name] 31-Jul-22 10:08am

if you can't use a debugger, it is enough to insert some println() in your code to inform of the actual state during execute

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2022-07-30T20:46:00

Look at your code: in the function version, when you find a match, you exit and return it which exits the loop.
In the non-function version, you print, but continue the loop. without changing any variables - so you get the same result the next time round, and never exit the loop.

To be honest, a couple of minutes or less with the debugger would have shown you exactly what was happening.

Patrice T · Answer 2 · 2022-07-30T20:38:00

Your code do not behave the way you expect, or you don't understand why !

There is an almost universal solution: Run your code on debugger step by step, inspect variables.
The debugger is here to show you what your code is doing and your task is to compare with what it should do.
There is no magic in the debugger, it don't know what your code is supposed to do, it don't find bugs, it just help you to by showing you what is going on. When the code don't do what is expected, you are close to a bug.
To see what your code is doing: Just set a breakpoint and see your code performing, the debugger allow you to execute lines 1 by 1 and to inspect variables as it execute.

Debugger - Wikipedia, the free encyclopedia[^]

Mastering Debugging in Visual Studio 2010 - A Beginner's Guide[^]
Basic Debugging with Visual Studio 2010 - YouTube[^]

jdb - The Java Debugger[^]
https://www.jetbrains.com/idea/help/debugging-your-first-java-application.html[^]

The debugger is here to only show you what your code is doing and your task is to compare with what it should do.

zemiak123 · Answer 3 · 2022-07-31T08:32:00

Solution 3

compare these two logics

target=1
mid= 3
if (1 < 14) true
if (1 > 14) false
else
 return 3 //mid, wrong answer
--------

target=1
mid= 3
if (1 < 14) true
else // next

mid=1
if (1 < 5) true
else // next

mid=0
if (1 < 1) false
else
if (1 > 1) false
else
 return 0 //mid, ok

Posted 31-Jul-22 8:32am

zemiak123

Updated 31-Jul-22 12:43pm

v2

By using while loop I get infinite lopp answer but where as by using same loop in functions I get correct answer HOW?

3 solutions

Solution 2

Solution 1

Solution 3

Add your solution here

Preview 0