How to line-through my li text with button click

Question

0.00/5 (No votes)

See more:

I have many li in an ol. And a "done" button.
I want that when I click on the button line-through the current list item with for loop or similar.

But I get an error:

Uncaught TypeError: Cannot read properties of undefined (reading 'innerHTML')
at done.<computed>.onclick (li_span_div_to_do_question.html:38:34)

Does somebody have an idea?

What I have tried:

HTML

<!DOCTYPE html>
<html>

<head>
    <meta charset='utf-8'>
    <meta http-equiv='X-UA-Compatible' content='IE=edge'>
    <title>Page Title</title>
    <meta name='viewport' content='width=device-width, initial-scale=1'>

</head>

<body>

    <div>
        <ol>
            <li class="to_buy">Melone</li><button class="done">Done</button>
            <li class="to_buy">Apple</li><button class="done">Done</button>
            <li class="to_buy">Banana</li><button class="done">Done</button>
            <li class="to_buy">Strawberry</li><button class="done">Done</button>
        </ol>
    </div>

    <script>

        var done = document.getElementsByClassName("done");
        var li = document.getElementsByClassName("to_buy")

        let li_collection

        for (i = 0; i < li.length; i++) {
            li_collection=li[i]
        }



        for (i = 0; i < done.length; i++) {
            done[i].onclick = function () {
                li_collection[i].innerHTML.style.textDecoration="line-through"
            }
        }

        console.log(li_collection)

    </script>
</body>

</html>

Posted 24-Jul-22 4:21am

folza

Updated 24-Jul-22 4:58am

Add a Solution

Comments

0x01AA 24-Jul-22 10:39am

~~From my point of view, your assumption that done has the same length like li_collection is wrong. You adress li_collection[i] while loop over done~~

folza 24-Jul-22 10:45am

How can I refer to the current li element to line-through? Do not you have a solution?

0x01AA 24-Jul-22 10:58am

Sorry, forget my comment above. It is a static html, therefore what I wrote is not correct.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

folza · Answer 1 · 2022-07-24T04:58:00

Solution 1

I have added this and works:

HTML

for (i = 0; i < done.length; i++) {
    done[i].onclick = function () {
        var div = this.previousElementSibling;
        div.style.textDecoration = "line-through";
    }
}

Posted 24-Jul-22 4:58am

folza