Click here to Skip to main content
15,908,111 members
Please Sign up or sign in to vote.
0.00/5 (No votes)
See more:
int[] ra =new int[100];
          Console.WriteLine("Number of element of the array..?");
          string s = Console.ReadLine();
          int x = int.Parse(s);
          Console.WriteLine("---------------");
          Console.WriteLine("Enter the array Elements");
          Console.WriteLine("---------------");
          for (int i=0;i<x;i++)
          {
              string s1 = Console.ReadLine();
              ra[i] = Int32. Parse(s1);
          }
          Console.WriteLine("---------------");
          Console.WriteLine("Enter search  Elements");
          Console.WriteLine("---------------");
          string s3 = Console.ReadLine();
          int x2 = Int32.Parse(s3);
          int low = 0;
          int high = x - 1;
          while (low <= high)
          {
              int mid = (low + high) / 2;
              if (x2 < ra[mid])
                  high = mid - 1;
              else if (x2 > ra[mid])
                  low=mid + 1;
              else if (x2 == ra[mid])
              {
                  Console.WriteLine("---------------");
                  Console.WriteLine("Search Successfully");
                  Console.WriteLine("---------------");
                  Console.WriteLine("Element{0} found at location{1}\n", x2, mid + 1);
                  return;
              }
          }
          Console.WriteLine("serach unsuccesfully");


What I have tried:

the error is shown here it is INT[] ra[i] = Int32. Parse(s1);
i enter the Element is 2
after that
12
21
find out the element is
12 is chosen the element first position like that I am not getting
Posted
Updated 2-Jul-22 2:33am

1 solution

First off, don't allocate ra until you have read the number of elements it needs to hold:
C#
int[] ra =new int[100];
Console.WriteLine("Number of element of the array..?");
string s = Console.ReadLine();
int x = int.Parse(s);
Should be written this way:
C#
Console.Write("Please enter the number of elements to sort: ");
string s = Console.ReadLine();
int noElements = int.Parse(s);
int[] ra = new int[noElements];
In fact, you should really use TryParse rather than Parse:
C#
int noElements;
do 
   {
   Console.Write("Please enter the number of elements to sort: ");
   string s = Console.ReadLine();
   } while (!int.TryParse(s, out noElements));
int[] ra = new int[noElements];
So that if the user mistypes, your app doesn't crash.
Use the same approach to element entry as well - there is nothing more annoying than entering 50 numbers and getting thrown out because you accidentally hit the wrong key ...

Then, you need to order your elements: if they aren't sorted, then a "binary chop" approach to searching will not work. For example, if I enter 1, 2, 3, 4, 5 and ask for 1 it will be found. But if I enter 5, 4, 3, 2, 1 it will never find anything other than the middle value!

Fix that lot, and then see how you code works. But remember: Compiling does not mean your code is right! :laugh:
Think of the development process as writing an email: compiling successfully means that you wrote the email in the right language - English, rather than German for example - not that the email contained the message you wanted to send.

So now you enter the second stage of development (in reality it's the fourth or fifth, but you'll come to the earlier stages later): Testing and Debugging.

Start by looking at what it does do, and how that differs from what you wanted. This is important, because it give you information as to why it's doing it. For example, if a program is intended to let the user enter a number and it doubles it and prints the answer, then if the input / output was like this:
Input   Expected output    Actual output
  1            2                 1
  2            4                 4
  3            6                 9
  4            8                16
Then it's fairly obvious that the problem is with the bit which doubles it - it's not adding itself to itself, or multiplying it by 2, it's multiplying it by itself and returning the square of the input.
So with that, you can look at the code and it's obvious that it's somewhere here:
C#
private int Double(int value)
   {
   return value * value;
   }

Once you have an idea what might be going wrong, start using the debugger to find out why. Put a breakpoint on the first line of the method, and run your app. When it reaches the breakpoint, the debugger will stop, and hand control over to you. You can now run your code line-by-line (called "single stepping") and look at (or even change) variable contents as necessary (heck, you can even change the code and try again if you need to).
Think about what each line in the code should do before you execute it, and compare that to what it actually did when you use the "Step over" button to execute each line in turn. Did it do what you expect? If so, move on to the next line.
If not, why not? How does it differ?
Hopefully, that should help you locate which part of that code has a problem, and what the problem is.
This is a skill, and it's one which is well worth developing as it helps you in the real world as well as in development. And like all skills, it only improves by use!
 
Share this answer
 
Comments
CPallini 2-Jul-22 12:23pm    
5.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)



CodeProject, 20 Bay Street, 11th Floor Toronto, Ontario, Canada M5J 2N8 +1 (416) 849-8900