I am trying to swap but getting out put as 7 and -2 after swaping not 7 and 5

Question

1.00/5 (1 vote)

See more:

#include <stdio.h>

int swap(int *x, int *y);

int main()
{

  int x, y;
  x = 5;
  y = 7;
  printf("%d and %d \n", x, y);
  swap(&x, &y);
  printf("%d and %d \n", x,y);

  return 0;
}

int swap(int *x, int *y)
{

  int temp;
  *x = temp;\\ swap function 
  *x = *y;
  *y = temp;
  return 0;
}

What I have tried:

Please give solution as per the code module do not add something which is from another level

Posted 28-May-22 9:01am

Aayush Jain 2022

Updated 28-May-22 9:19am

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

CPallini · Accepted Answer · 2022-05-28T09:19:00

Your swap function is just wrong, the temp variable should be use to maintain the original value of x.
Try

C

#include <stdio.h>

void swap(int *x, int *y);

int main()
{

  int x, y;
  x = 5;
  y = 7;
  printf("%d and %d \n", x, y);
  swap(&x, &y);
  printf("swapped: %d and %d \n", x,y);

  return 0;
}

void swap(int *x, int *y)
{// swap function 
  int temp = *x;
  *x = *y;
  *y = temp;
}