How to pass int array in SQL parameterized query to in clause using idbconnection

Question

1.00/5 (1 vote)

See more:

I have an SQL query that uses string format to insert the int array(pubIds) into the query argument which is set to CommandText (As inserted below). Although this works fine, I have a fortify SQL injection vulnerability detected here and need to fix it.

C#

using (IDbCommand cmd = conn.createCommand())
{
  cmd.CommandType = CommandType.Text;
  cmd.CommandText = string.Format(Query, string.Join(", ", pubIds))

I am trying to parameterise the query as a resolution.
Can Someone help me with it. as solutions found online are mostly using sql command. is there a diff way to solve the issue.

What I have tried:

https://stackoverflow.com/questions/337704/parameterize-an-sql-in-clause

https://stackoverflow.com/questions/20739578/pass-string-array-as-parameter-in-sql-query-in-c-sharp

Posted 28-Mar-22 21:56pm

Member 15572024

Updated 29-Mar-22 2:49am

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard Deeming · Answer 1 · 2022-03-29T02:49:00

Simple enough:

C#

using (IDbCommand cmd = conn.createCommand())
{
    List<string> parameterNames = new List<string>();
    foreach (var pubId in pubIds)
    {
        string parameterName = "@p" + parameterNames.Count);
        parameterNames.Add(parameterName);
        
        var parameter = cmd.CreateParameter();
        parameter.ParameterName = parameterName;
        parameter.Value = pubId;
        // TODO: Specify the correct type and size/precision/scale to match your database.
        cmd.Parameters.Add(parameter);
    }
    
    cmd.CommandType = CommandType.Text;
    cmd.CommandText = string.Format(Query, string.Join(", ", parameterNames));

NB: Your scanner may still flag this code for review, depending on how clever it is. But since you're only inserting parameter names into the query, and passing all data values as parameters, the code is not obviously vulnerable.

(If you're using dynamic SQL incorrectly, the code could still be vulnerable; but without seeing the full query, there's no way to know for sure.)