Why data column is not adding properly to the datatable

Question

1.00/5 (2 votes)

See more:

Hi,

I have one data table having datas from DB

once the data table loaded i need to add one "Name" colum in the first position.My code is not giving a proper structure after adding new data column. What error i am doing here?

What I have tried:

C#

using (var adapter = new OdbcDataAdapter(command))

           {

               command.CommandTimeout = 280;

               var table = new DataTable(tableName);



               if (tableName == "TestData")

               {

                   var pathC = @"H:\file\data\names.txt";

                   string[] result = File.ReadAllLines(pathC);


                   DataColumn Col = table.Columns.Add("Name", typeof(String));

                   Col.SetOrdinal(0); // set column to first position

                   int i = 0;

                   foreach (DataRow row in table.Rows)

                   {

                       //need to set value to NewColumn column

                       row["Name"] = result[i];

                       i++;

                   }

               }



               adapter.Fill(table);



               return table;

           }

Posted 9-Dec-21 3:06am

Manidas Payyoli

Updated 9-Dec-21 22:40pm

PIEBALDconsult

v2

Add a Solution

Comments

CHill60 9-Dec-21 9:21am

At quick glance I would say it's because you call adapter.Fill(table); after adding the column - try doing that first

[no name] 9-Dec-21 9:32am

tried but new coloumn started from 6th row of DT.5 rows are loaded from db.new coloumn started from 6th nut 0th position

CHill60 9-Dec-21 9:56am

On which line

[no name] 9-Dec-21 9:59am

index issue resolved.but new coloumn started from 6th row of DT.5 rows are loaded from db.new coloumn started from 6th nut 0th position

CHill60 9-Dec-21 10:02am

What index issue? I asked which line produced the exception!

[no name] 9-Dec-21 10:17am

there is no exception, data loading as 0 th postion but after 5th row only newly added colom is loading.Till 5th row database values are loaded. i was getting an index issue befor that one i fixed.

CHill60 9-Dec-21 12:06pm

It might be easier if you actually included this data in your question. Do you mean the datatable ends up looking like this

Name1 database-data
Name2 database-data
Name3 database-data
Name4 database-data
Name5 database-data
Name6 blank
Name7 blank

[no name] 9-Dec-21 12:45pm

NAME colom coming from txt file. empty cells left blank here.Header loding correctly from SCHOOL but data starts from last row

NAME SCHOOL PLACE
SAM
JAM
DAM
HAM SCHOOL1 PLACE1

[no name] 9-Dec-21 12:45pm

this is the code

if (tableName == "TestData")

{

var pathC = @"H:\claimdetails\claims\names.txt";

string[] result = File.ReadAllLines(pathC);

DataColumn Col = table.Columns.Add("Name", typeof(String));

Col.SetOrdinal(0); // set column to first position

DataRow row;

for (int i = 0; i < result.Length; i++)

{

row = table.NewRow();

row["Name"] = result[i];

table.Rows.Add(row);

}

}

adapter.Fill(table);

Richard Deeming 9-Dec-21 9:57am

REPOST
This is at least your FOURTH copy of the same question!
How to add a text file into dtatatable column as first column[^]
How to add a data column to existing data table[^]
Cannot apply indexing with [] to an expression of type 'system.collections.generic.ienumerable<>[^]

[no name] 9-Dec-21 10:01am

tried diffrenet solution but no result

Richard Deeming 9-Dec-21 10:14am

That's not an excuse to keep re-posting the same question!

If you want to update your question with additional information, click the green "Improve question" link and edit your question. Do not post a "new" question with the updated information.

[no name] 9-Dec-21 10:18am

thanks..ill care coming forwRD

2 solutions

Solution 1

You can try this,
using(var adapter = new OdbcAdapter(command))
{
command.CommandTimeout = 280;
var table = new DataTable(tablename);
if(tablename =="TestData");
{
var pathC = @"H:\file\data\names.txt";
string[]result = File.ReadAllText(pathC).Split('\n');
DataColumn Col = table.Columns.Add("Name",typeof(String));
Col.SetOrdinal(0);//set column to first position
int i=0;
foeeach (DataRow row in table.Rows)
{
row["Name"]=result[i];
i++;
}
}
adapter.Fill(table);
return table;
}

Posted 9-Dec-21 21:44pm

Member 15462473

Comments

[no name] 10-Dec-21 4:19am

only column name is loading..no data in first column

CHill60 10-Dec-21 4:30am

Reasons for my vote of 1:
- You have also put adapter.Fill(table); in the wrong place - it needs to be filled before adding the new column
- Pointless change of OdbcAdapter to OdbcDataAdapter - the OP is not having any problems reading their database
- Really pointless change to use string[]result = File.ReadAllText(pathC).Split('\n'); - Has the same effect as ReadAllLines and the latter is far more efficient
- Spot the problem with this line

if(tablename =="TestData");

- the statement block following this "if" statement will always be executed regardless of the tablename
- This has clearly not even been compiled never minded tested -

foeeach (DataRow row in table.Rows)

[no name] 10-Dec-21 5:31am

if(tablename =="TestData");-- have number of tables in the the DS so only with this
table name i need to add extra column.

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

CHill60 · Accepted Answer · 2021-12-09T22:40:00

Please look at my very first comment

Quote:
At quick glance I would say it's because you call adapter.Fill(table); after adding the column - try doing that first

Change your code to fill the table before you even attempt to add a column

Based on your new code in your comment you are now adding new rows to the table instead of filling in the new column details

Try something like this (warning, not tested or compiled):

C#

adapter.Fill(table);
if (tablename == "TestData")
{
	var pathC = @"H:\claimdetails\claims\names.txt";

	string[] result = File.ReadAllLines(pathC);

	DataColumn Col = table.Columns.Add("Name", typeof(String));

	Col.SetOrdinal(0); // set column to first position

    foreach (DataRow row in table.Rows)
    {
        row["Name"] = result[i++];
    }
}

// REMOVE this from here adapter.Fill(table);