How to overwrite a search value?

Question

0.00/5 (No votes)

See more:

Good day,
I do a text search in in file in the WPF application, which I would then rewrite. I'm completely confused about what to write as a rewritten value. The problem is that the found lines are overwritten, but depending on the number of them in the document, the whole text is copied many times.

I will be very happy for any advice or solution
Thank you!!!

What I have tried:

C#

private void Grid_Loaded(object sender, RoutedEventArgs e)
       {
           TextBox.Focus();
       }

       private void HledatButton_Click(object sender, RoutedEventArgs e)
       {
           string file = TextBox.Text;
           List<string> files = Directory.GetFiles(file, "*.csproj", SearchOption.AllDirectories).ToList();
           foreach (string pathFile in files)
           {
               string[] lines = File.ReadAllLines(pathFile);
               var newPath = "C:\\ArcGISPro\\bin\\";
               var path = @"C:\Program Files\ArcGIS\Pro\bin\";
               List<string> updateLines = new List<string>();
               for (int index = 0; index < lines.Length; index++)
               {
                   string line = lines[index];
                   if (line.Contains(path))
                   {
                       foreach (string s in lines)
                       {

                           line = s.Replace(path, newPath);
                           updateLines.Add(line);
                       }
                   }
                   File.WriteAllLines(newPath, updateLines);
               }
           }
           MessageBox.Show("DONE!");
       }

Posted 7-Nov-21 19:57pm

dejf111

Updated 7-Nov-21 23:26pm

v3

Add a Solution

Comments

Richard Deeming 9-Nov-21 5:52am

REPOST
This is the same question you posted last week, which you marked as "solved":
How to overwrite a line in a file?[^]

dejf111 9-Nov-21 6:37am

If you read it better, it's a question of something else.

Richard Deeming 9-Nov-21 6:39am

It's exactly the same: you're changing lines in a file. In both questions, you're overwriting the file every time you find a matching line, rather than when you've finished processing the file.

The only difference is that you're now processing multiple files instead of just one.

dejf111 9-Nov-21 6:45am

I mentioned that you must know best, I'm sorry :)

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2021-11-07T20:16:00

Solution 1

That's not going to work.
I'm not at all sure what you expect it to do, but it's not going to do it.

C#

for (int index = 0; index < lines.Length; index++)
{
    string line = lines[index];
    if (line.Contains(path))
    {
        foreach (string s in lines)
        {

            line = s.Replace(path, newPath);
        }
    }
    File.WriteAllLines(newPath, lines);
}

1) You loop through all lines
2) Inside that loop, if the string is found, you loop through all lines again
3) Inside that loop, you set the same variable to many different values.
4) You ignore the value you changed and write the original input out to the new file.
5) The path you output to isn't a file, but a folder.

Many things just look weird here: which probably means you leapt straight into code without thinking about what your task was and the best way to manage or implement it.

I'd strongly suggest that you start again: think about exactly what you need to do, and work out what the code flow should be before you start coding - because whatever your task is, that isn't a good solution!

Posted 7-Nov-21 20:16pm

OriginalGriff

Comments

dejf111 8-Nov-21 2:26am

I expect it to read all the folders in the file that have a .csproj extension. Subsequently, it will find the searched text in the individual folders, which it will replace with my new text. He then writes the corrected one back to that folder.

OriginalGriff 8-Nov-21 2:45am

So think about the operations that need to be done to do that: as I siad, the existing code won't do that, and looks like it was thrown together without much advance planning.

But the real question is why are you doing that at all? Duplicating projects isn't a good way to do anything as it quickly leads to configuration nightmares when changes occur, particularly if you try to overwrite existing code as it may not even get compiled into other projects because the files dates will be wrong. If you are trying to reuse code, then do it via the VS mechanism(s): references, and existing projects. They handle it for you.

dejf111 8-Nov-21 3:03am

I've already figured it out but thank you for the advice

dejf111 8-Nov-21 3:45am

Modified question, new error. Now the text is copied as many times as the text contains the search term.

OriginalGriff 8-Nov-21 4:10am

And why do you think that is?
Have you tried the debugger yet?

dejf111 8-Nov-21 4:24am

I use a debbuger but it didn't tell me why it was

OriginalGriff 8-Nov-21 4:53am

Debuggers don't show you *why* - they show you exactly *what* is happening.
Your job is to compare what does happen with what you expected to happen, and when it differs work out why!

So what does the debugger show you is happening that you didn't expect, or not happening that you did?

dejf111 8-Nov-21 5:03am

Showed me that it always writes a value when it has if statement = true

OriginalGriff 8-Nov-21 5:12am

So ... is it supposed to be true at that point? Or not?
Remember: you wrote the code, you know what you intended it to do. The debugger doesn't - it just shows you what it does do!

You still haven't thought much about this task: for example - and it's only one example - what do you do with updateLines?

dejf111 8-Nov-21 5:27am

I add lines to it and then write to the document.

OriginalGriff 8-Nov-21 6:08am

Do you?
What do you write to the document?
And while we're there, what's the file name you write to?

dejf111 8-Nov-21 6:31am

The name is clearly written in the sheet in which the searched files are listed.After all, this is evident from the code. Do you want to advise me or not?

OriginalGriff 8-Nov-21 6:42am

:sigh:
Read your code.
Use the debugger.
What - exactly - is in newPath (now you have actually done something with updateLines, even if that isn't going to work ... it's a collection, not a single line of text)?